Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be allowed to set remote --spawn_strategy without remote_executor set #13340

Closed
brentleyjones opened this issue Apr 13, 2021 · 0 comments
Assignees
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request

Comments

@brentleyjones
Copy link
Contributor

Description of the problem / feature request:

Currently, if you set a manual --spawn_strategy that includes remote, but remote_executor isn't set, you get an error about an unknown spawn strategy (because the RemoteModule isn't loaded). This makes it very difficult to customize the spawn strategy that should be used (e.g. disabling sandboxing on macOS, but conditionally enabling remote execution).

Instead of preventing remote, it should simply ignore it if remote_executor is not set. This would allow customizing the default --spawn_strategy (which conditionally adds remote).

Feature requests: what underlying problem are you trying to solve with this feature?

The ability to easily customize --spawn_strategy while conditionally using remote execution.

What operating system are you running Bazel on?

macOS

What's the output of bazel info release?

release 4.0.0

@jin jin added team-Remote-Exec Issues and PRs for the Execution (Remote) team untriaged labels Apr 14, 2021
@coeuvre coeuvre added P2 We'll consider working on this in future. (Assignee optional) type: feature request and removed untriaged labels May 12, 2021
@coeuvre coeuvre self-assigned this May 12, 2021
coeuvre added a commit to coeuvre/bazel that referenced this issue May 19, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without set `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.
coeuvre added a commit to coeuvre/bazel that referenced this issue May 20, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without set `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.
coeuvre added a commit to coeuvre/bazel that referenced this issue Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this issue Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this issue Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this issue Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this issue Jul 16, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants