Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup progress when using bzlmod #17130

Closed
keith opened this issue Jan 4, 2023 · 1 comment
Closed

Cleanup progress when using bzlmod #17130

keith opened this issue Jan 4, 2023 · 1 comment
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug untriaged

Comments

@keith
Copy link
Member

keith commented Jan 4, 2023

Currently when using bzlmod your action's progress can look something like @_main~bzlmod_tool_dependencies~Yams//:Yams, in the past this would have been displayed as @Yams//:Yams and generally IMO this adds a lot of visual noise if you have many dependencies like this.
@fmeum fmeum mentioned this issue Jan 4, 2023
Closed
@fmeum
Copy link
Collaborator

fmeum commented Jan 4, 2023

I have a PR that should fix this: #17045

@ShreeM01 ShreeM01 mentioned this issue Jan 20, 2023
Merged
hvadehra pushed a commit that referenced this issue Feb 14, 2023
@fmeum @hvadehra
Prettify labels in action progress messages with Bzlmod
151e1a4 
`UiStateTracker` is provided with the repository mapping of the main repository after the loading phase has been completed and uses this mapping to "unmap" canonical labels back to the apparent name used for them by the main repository.

Fixes #17130

Closes #17045.

PiperOrigin-RevId: 501256229
Change-Id: I796585da07773ee3a589bb83948b9e0667b2e799
ShreeM01 added a commit that referenced this issue Feb 14, 2023
@ShreeM01 @fmeum
Prettify labels in action progress messages with Bzlmod (#17278)
4e35c02 
`UiStateTracker` is provided with the repository mapping of the main repository after the loading phase has been completed and uses this mapping to "unmap" canonical labels back to the apparent name used for them by the main repository.

Fixes #17130

Closes #17045.

PiperOrigin-RevId: 501256229
Change-Id: I796585da07773ee3a589bb83948b9e0667b2e799

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prettify labels in action progress messages with Bzlmod fmeum/bazel
3 participants
@keith @fmeum and others