Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Ensure outputs are downloaded before sending TargetComplete event via BEP #18333

Closed
bazel-io opened this issue May 5, 2023 · 1 comment
Closed

[6.3.0] Ensure outputs are downloaded before sending TargetComplete event via BEP #18333

bazel-io opened this issue May 5, 2023 · 1 comment
Milestone
6.3.0 release blo...

Comments

@bazel-io
Copy link
Member

bazel-io commented May 5, 2023

Forked from #17798
@bazel-io bazel-io added this to the 6.3.0 release blockers milestone May 5, 2023
@coeuvre coeuvre mentioned this issue Jun 29, 2023
Merged
coeuvre added a commit that referenced this issue Jun 30, 2023
@coeuvre
Wait for outputs downloads before emitting local BEP events that refe…
14895f0 
…rence these outputs. (#18815)

This is a workaround for 6.3.0. At HEAD, we download these outputs during action execution so there is no need to wait when emitting events.

Fixes #18333
@coeuvre
Copy link
Member

coeuvre commented Jun 30, 2023

Fixed by #18815.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0 release blockers
Development

No branches or pull requests
3 participants
@coeuvre @bazel-io @iancha1992