Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Update windows VS detection code to account for new directory #18799

Closed
bazel-io opened this issue Jun 28, 2023 · 1 comment
Closed

[6.3.0] Update windows VS detection code to account for new directory #18799

bazel-io opened this issue Jun 28, 2023 · 1 comment
Milestone
6.3.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #18608
@bazel-io bazel-io added this to the 6.3.0 release blockers milestone Jun 28, 2023
@keertk
Copy link
Member

keertk commented Jul 10, 2023

Decided against cherry-picking this into 6.3.

@keertk keertk closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
@Vertexwahn Vertexwahn mentioned this issue Jul 14, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Jul 17, 2023
@Vertexwahn @copybara-github
Fix VS 2022 autodetection
cd33d14 
This is the same PR as #18608 but extended by the modification proposed by @meteorcloudy

This should fix #18592

Should also be picked to 6.3.0 -> #18799

Closes #18945.

PiperOrigin-RevId: 548725707
Change-Id: Iff0f972c9fc23491c8070ee2b12ec600a3d1ead9
iancha1992 pushed a commit to iancha1992/bazel that referenced this issue Jul 17, 2023
@Vertexwahn @iancha1992
Fix VS 2022 autodetection
6fd8154 
This is the same PR as bazelbuild#18608 but extended by the modification proposed by @meteorcloudy

This should fix bazelbuild#18592

Should also be picked to 6.3.0 -> bazelbuild#18799

Closes bazelbuild#18945.

PiperOrigin-RevId: 548725707
Change-Id: Iff0f972c9fc23491c8070ee2b12ec600a3d1ead9
@iancha1992 iancha1992 mentioned this issue Jul 17, 2023
Merged
iancha1992 added a commit that referenced this issue Jul 19, 2023
@iancha1992 @Vertexwahn
Fix VS 2022 autodetection (#18960)
b13091a 
This is the same PR as #18608 but extended by the modification proposed by @meteorcloudy

This should fix #18592

Should also be picked to 6.3.0 -> #18799

Closes #18945.

PiperOrigin-RevId: 548725707
Change-Id: Iff0f972c9fc23491c8070ee2b12ec600a3d1ead9

Co-authored-by: Vertexwahn <julian.amann@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0 release blockers
Development

No branches or pull requests
2 participants
@bazel-io @keertk