Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept label_string_dict for includes #2611

Closed
abergmeier-dsfishlabs opened this issue Mar 1, 2017 · 2 comments
Closed

Accept label_string_dict for includes #2611

abergmeier-dsfishlabs opened this issue Mar 1, 2017 · 2 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) type: feature request

Comments

@abergmeier-dsfishlabs
Copy link
Contributor

Description of the problem / feature request / question:

Once we have label_string_dict (or whatever it will be called), it would be great if the reach of include statements could be controlled by labelled dicts. Something like:

includes = {
  "//visibility:public": "include/",
  "//visibility:private": "src/",
},

where public gets derived by dependants.

@vladmos vladmos added category: extensibility > skylark P2 We'll consider working on this in future. (Assignee optional) type: feature request labels Mar 6, 2017
@laurentlb
Copy link
Contributor

I need more context. Are you talking about the C++ rules?

@abergmeier-dsfishlabs
Copy link
Contributor Author

I need more context. Are you talking about the C++ rules?

Yes. I do think though, that this is not the best idea. Would rather have it accept a custom object, which wraps visibility similar to select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants