Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve include directories support #6790

Closed
hlopko opened this issue Nov 28, 2018 · 4 comments
Closed

Improve include directories support #6790

hlopko opened this issue Nov 28, 2018 · 4 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request

Comments

@hlopko
Copy link
Member

hlopko commented Nov 28, 2018

Project to improve expressiveness of includes. We need non transitive includes, proper support in the crosstool, and we need to stop parsing copts to detect all includes for header validation.

Problems:

Related issues:

@hlopko hlopko added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Jan 9, 2019
@hlopko
Copy link
Member Author

hlopko commented Mar 28, 2019

Relevant discussion: #6343

@scentini scentini assigned hlopko and unassigned scentini Jun 4, 2019
@scentini scentini assigned scentini and unassigned hlopko Jul 22, 2019
@scentini scentini added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Jul 22, 2019
@scentini
Copy link
Contributor

scentini commented Sep 2, 2019

This will not make it into 1.0.

@dslomov dslomov removed the bazel 1.0 label Sep 2, 2019
@elklein
Copy link
Contributor

elklein commented Mar 16, 2020

Any news on the status of this issue? I've hit up against it. I'm able to hack around it be using a pre-existing wrapper that we have around gcc (so that we can dispatch work to either gcc or nvcc) to hack certain -I flags over to -isystem instead, but that's clearly not a very nice solution. Would love to be able to use a proper system to designate which includes should be -I vs. -isystem. Thanks!

@meisterT meisterT added untriaged and removed P1 I'll work on this now. (Assignee required) labels May 12, 2020
@oquenchil oquenchil added help wanted Someone outside the Bazel team could own this P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed untriaged labels May 12, 2020
@c-mita c-mita removed the help wanted Someone outside the Bazel team could own this label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Development

No branches or pull requests

9 participants