Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for Starlark Rule Output API changes #6241

Closed
c-parsons opened this issue Sep 25, 2018 · 4 comments
Closed

Tracking issue for Starlark Rule Output API changes #6241

c-parsons opened this issue Sep 25, 2018 · 4 comments
Assignees
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required)

Comments

@c-parsons
Copy link
Contributor

This will serve as a tracking issue for the proposal found at Fixing Starlark Rule Outputs
(attached to semantics flag --incompatible_outputs_api)

@c-parsons c-parsons self-assigned this Sep 25, 2018
@c-parsons
Copy link
Contributor Author

Based on in-team discussion, we'll separate out the fixes proposed in the above doc and use different flags for them.

This issue will still track the comprehensive work, as the fixes are semi-related.

bazel-io pushed a commit that referenced this issue Oct 1, 2018
…ed Target.output_group field.

Progress toward #6241

RELNOTES: None.
PiperOrigin-RevId: 215238373
@laurentlb laurentlb added P1 I'll work on this now. (Assignee required) incompatible-change Incompatible/breaking change labels Nov 21, 2018
bazel-io pushed a commit that referenced this issue Nov 21, 2018
Progress toward #6241

RELNOTES: None.
PiperOrigin-RevId: 222463226
bazel-io pushed a commit that referenced this issue Feb 4, 2019
This object is opaque but can be constructed with a new API method coverage_common.instrumented_files_info(). This should be a drop-in replacement for returning instrumented_files in rule implementation functions, as that syntax is going away.

See https://docs.google.com/document/d/14A9HK8Jn2jErMayLEE3nrNJIxNfZWN_slFbhgtS6-aM for details.

Progress toward #6241

RELNOTES: None.
PiperOrigin-RevId: 232310117
bazel-io pushed a commit that referenced this issue Feb 5, 2019
Such functions should return a list of providers instead.
This change represents a deprecation of the "old" syntax.

This is an incompatible change attached to new flag --incompatible_disallow_struct_provider_syntax.

See https://docs.google.com/document/d/14A9HK8Jn2jErMayLEE3nrNJIxNfZWN_slFbhgtS6-aM for details.

Migration tracker: #7347
Progress toward #6241

RELNOTES: New incompatible flag --incompatible_disallow_struct_provider_syntax removes the ability for rule implementation functions to return struct. Such functions should return a list of providers instead. Migration tracking: #7347
PiperOrigin-RevId: 232547460
@laurentlb
Copy link
Contributor

Is it migration-ready?
When it is, the issue title should start with the flag name (if there are multiple flags, create multiple issues).

@laurentlb
Copy link
Contributor

Shall we close this bug?

@c-parsons
Copy link
Contributor Author

Sure -- the other issues I've opened should track the remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible-change Incompatible/breaking change P1 I'll work on this now. (Assignee required)
Projects
None yet
Development

No branches or pull requests

2 participants