Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output the actual path of virtual include headers in the coverage report #6254

Closed
iirina opened this issue Sep 26, 2018 · 0 comments
Closed

Output the actual path of virtual include headers in the coverage report #6254

iirina opened this issue Sep 26, 2018 · 0 comments
Assignees
@iirina
Labels
coverage P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules

Comments

@iirina
Copy link
Contributor

iirina commented Sep 26, 2018

The code coverage report must include the actual paths to header files instead of the ugly,
Bazel generated, virtual includes path.

For example, the SF: (source file) lines in the coverage report must look like this:

SF:include/common/strategy.h

instead of

SF:bazel-out/k8-fastbuild/bin/include/common/_virtual_includes/strategy/strategy.h
@iirina iirina added P2 We'll consider working on this in future. (Assignee optional) coverage team-Rules-CPP Issues for C++ rules labels Sep 26, 2018
@iirina iirina self-assigned this Sep 26, 2018
@iirina iirina mentioned this issue Sep 26, 2018
Closed
bazel-io pushed a commit that referenced this issue Sep 27, 2018
@iirina
Add virtual includes coverage test.
154c8ae 
Test for #6254.

Closes #6255.

PiperOrigin-RevId: 214744841
@iirina iirina mentioned this issue Oct 12, 2018
Closed
@nacl nacl mentioned this issue Jul 30, 2020
Open
@shrouxm shrouxm mentioned this issue Nov 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iirina iirina

Labels
coverage P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iirina