Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform/toolchain support for Java rules #6521

Closed
gregestren opened this issue Oct 25, 2018 · 6 comments
Closed

Platform/toolchain support for Java rules #6521

gregestren opened this issue Oct 25, 2018 · 6 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions

Comments

@gregestren
Copy link
Contributor

Tracking issue on Bazel Configurability Roadmap

Goal:

  • Java toolchains can be defined with Bazel's generic toolchain machinery
  • Java rules read these toolchains
  • Java rules resolve properly against platforms
@gregestren gregestren added P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions labels Oct 25, 2018
@gregestren
Copy link
Contributor Author

gregestren commented Oct 25, 2018 •
edited
Loading

@katre / @aiuto - can you provide better info about the path forward?

@katre
Copy link
Member

katre commented Oct 25, 2018

Yes! We have a commitment for work early next year.

@hlopko
Copy link
Member

hlopko commented Feb 6, 2019

CC @hlopko :)

@shs96c shs96c mentioned this issue Mar 28, 2019
Closed
@gregestren
Copy link
Contributor Author

April '19 update::

I think all three items above are now ready with --experimental_disallow_legacy_java_toolchain_flags. Is there anything left for this issue aside from having appropriate toolchain and platform instances defined in good places?

Also, what's the path for this being available non-experimentally?

@iirina @cushon

@cushon
Copy link
Contributor

cushon commented Apr 26, 2019

Is there anything left for this issue aside from having appropriate toolchain and platform instances defined in good places?

Not as far as I know. We're using it internally and I'm going to flip --experimental_disallow_legacy_java_toolchain_flags soon.

I think @iirina owns the migration for bazel.

@aiuto aiuto removed their assignment Jun 5, 2019
bazel-io pushed a commit to bazelbuild/platforms that referenced this issue Jun 18, 2019
@hlopko @copybara-github
Use cpu and os constraints from Bazel platforms repository
5f13869 
bazelbuild/bazel#6516
bazelbuild/bazel#6521

RELNOTES: None.
PiperOrigin-RevId: 253828017
Change-Id: I15f0295e8759357f481984d361977de2deebac13
bazel-io pushed a commit to bazelbuild/rules_java that referenced this issue Jun 21, 2019
@hlopko @copybara-github
Move java constraints to rules_java
7d0cded 
bazelbuild/bazel#6516
bazelbuild/bazel#6521

PiperOrigin-RevId: 254374629
Change-Id: I9fd82cbf8d244a0419026b75cfda83894859dbbd
bazel-io pushed a commit that referenced this issue Jun 21, 2019
@hlopko @copybara-github
Move java constraints to rules_java
b95f381 
#6516
#6521

PiperOrigin-RevId: 254374629
@iirina iirina mentioned this issue Jul 3, 2019
Closed
siberex pushed a commit to siberex/bazel that referenced this issue Jul 4, 2019
@hlopko @siberex
Move java constraints to rules_java
2b5fd16 
bazelbuild#6516
bazelbuild#6521

PiperOrigin-RevId: 254374629
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@hlopko @irengrig
Move java constraints to rules_java
6fb433d 
bazelbuild#6516
bazelbuild#6521

PiperOrigin-RevId: 254374629
@dslomov dslomov removed the bazel 1.0 label Sep 2, 2019
@katre
Copy link
Member

katre commented May 11, 2020

This is a duplicate of #4592, closing it in favor of that issue.

@katre katre closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@katre @cushon @hlopko @aiuto @dslomov @gregestren