incompatible_remove_native_maven_jar #6799

dkelmer · 2018-11-29T02:25:45Z

The native maven_jar rule will no longer be available with this flag set to true.

(Update: managed by @jin as of July 12)

A migration tool will be provided to automatically convert maven_jar targets to rules_jvm_external's maven_install rule, and modify BUILD files to use the new labels.

See https://docs.google.com/document/d/1CqxPv-TwvFWBHgtg7_QhVfck4vH4rnmCU_IuMdC7O2M/edit# for a design document of this migration tool.

Proposal by @dkelmer as of Nov 28, which is another valid migration solution that is done manually:

Use

load("@bazel_tools//tools/build_defs/repo:java.bzl", "java_import_external")

or the convenience wrapper

load("@bazel_tools//tools/build_defs/repo:jvm.bzl", "jvm_maven_import_external")

instead.

Given a WORKSPACE file that looks like the following:

maven_jar(
    name = "truth",
    artifact = "com.google.truth:truth:0.30",
    sha1 = "9d591b5a66eda81f0b88cf1c748ab8853d99b18b",
)

It will need to look like this after updating:

load("@bazel_tools//tools/build_defs/repo:jvm.bzl", "jvm_maven_import_external")
jvm_maven_import_external(
    name = "truth",
    artifact = "com.google.truth:truth:0.30",
    artifact_sha256 = "59721f0805e223d84b90677887d9ff567dc534d7c502ca903c0c2b17f05c116a",
    server_urls = ["http://central.maven.org/maven2"],
    licenses = ["notice"],  # Apache 2.0
)

Notably

the licenses attribute is mandatory
sha1 is no longer supported, only sha256 is
the server_urls attribute is mandatory. If your maven_jar rule did not specify a url
then you should use the default server ("http://central.maven.org/maven2"). If your rule
did specify a url then keep using that one.

The text was updated successfully, but these errors were encountered:

Closes #6768. Relevant to #6799. PiperOrigin-RevId: 223375698

meteorcloudy · 2019-01-03T09:25:13Z

This flag will break many projects in downstream, you can see the details at
https://buildkite.com/bazel/bazel-at-release-plus-incompatible-flags/builds/48

Please help them migrate (by filing issues and sending PRs and pinging the owners), thanks!

dkelmer · 2019-01-16T22:14:41Z

meisterT · 2019-02-03T16:48:56Z

cc @vladmos this is a classical example where buildifier could help with fixing the projects, because it's a mostly mechanical change

Danna: it would be great if we could prioritize this migration, because the maven rules are one of the two "users" of the java.desktop module which contributes to 1/3 of the embedded JDK size.

See bazelbuild/bazel#6799 for more details

dkelmer · 2019-02-06T14:27:35Z

merged: bazelbuild/rules_gwt#20
merged: bazelbuild/rules_appengine#96
merged: https://critique.corp.google.com/#review/229611659&tab=a (intellij, SOT is internal)
merged: grpc/grpc-java#5327
merged: android/testing-samples#245
filed issue: bazelbuild/BUILD_file_generator#48 (they use bazel-deps and updating requires updating their custom scripts so I'll leave that to them)

rules_k8s is breaking because of grpc, so marking it as fixed

See bazelbuild/bazel#6799 for more details

meteorcloudy · 2019-02-12T09:27:05Z

Since this flag is still not flipped in 0.22, 0.22 should still be its migration window.

guw · 2019-02-15T20:12:30Z

Going through the examples above, how would one specify a Maven server which requires authentication?

The native.maven_rule has a server attribute which takes a name of a server. Authentication credentials for such a server would be specified in ~/.m2/settings.xml. The location of the settings file was configurable with native.maven_server rule.

dkelmer · 2019-02-21T21:30:16Z

Thanks for bringing this up, the native maven_jar rule will not be deprecated before there is support for authentication with a local maven server

This removes our dependency on the deprecated native maven_jar rule: bazelbuild/bazel#6799 All changes except maven_dependencies.yaml are generated by the tool. At the same time, remove missing-jar-workaround.sh, which I haven't needed for some time. Change-Id: I22e15e340d98183156ef5942d0a11f4a759c6baa GitOrigin-RevId: 525db49

dapengzhang0 · 2019-03-05T21:50:57Z

@dkelmer How did you get the sha256 values? As the default server ("http://central.maven.org/maven2") only provides sh1. Is there an automated tool that can get sha256 values for a lot of dependent maven jars?

dkelmer · 2019-03-05T23:02:42Z

@dapengzhang0 There is not an automated tool. You need to independently fetch the jars and calculate the sha256. One thing you can do is omit the artifact_sha256 attribute and run bazel fetch. Bazel will then tell you what sha it expected for each jar.

jin · 2019-09-12T15:53:50Z

That would be 1.0.0rc1. https://releases.bazel.build/1.0.0/rc1/index.html

JLLeitschuh · 2019-09-24T03:47:47Z

Hey @jin unless Google plans to make an official disclosure for this, the CVE to use is the generic one for SHA-1 https://nvd.nist.gov/vuln/detail/CVE-2005-4900

jin · 2019-10-30T21:42:18Z

Please see this document for a design proposal for a migration tool from maven_jar to rules_jvm_external.

JLLeitschuh · 2019-10-31T02:17:20Z

Thanks! Cool to see progress on this!

jin · 2019-11-14T16:46:58Z

The automated migration tool is available here: https://github.com/bazelbuild/rules_jvm_external/tree/master/migration

If you don't wish to migrate to rules_jvm_external, please follow the alternative instructions to manually migrate to jvm_maven_import_external.

Context: bazelbuild/bazel#6799

Baseline: 807ed23 Cherry picks: + db0e32c: build.sh: Fix bug in build script for RC release + 85e84f7: Set --incompatible_prohibit_aapt1 default to true. + 84eae2f: Let shellzelisk fallback to bazel-real if it's the requested version. + d5ae460: Fix a typo in bazel.sh Incompatible changes: - --incompatible_remap_main_repo is enabled by default. Therefore, both ways of addressing the main repository, by its name and by '@' are now considered referring to the same repository. see #7130 - --incompatible_disallow_dict_lookup_unhashable_keys is enabled by default #9184 - --incompatible_remove_native_maven_jar is now enabled by default and the flag removed. See #6799 - --incompatible_prohibit_aapt1 is enabled by default. See #10000 Important changes: - --incompatible_proto_output_v2: proto v2 for aquery proto output formats, which reduces the output size compared to v1. Note that the messages' ids in v2 are in uint64 instead of string like in v1. - Adds --incompatible_remove_enabled_toolchain_types. - Package loading now consistently fails if package loading had a glob evaluation that encountered a symlink cycle or symlink infinite expansion. Previously, such package loading with such glob evaluations would fail only in some cases. - The --disk_cache flag can now also be used together with the gRPC remote cache. - An action's discover inputs runtime metrics is now categorized as parse time on the CriticalPathComponent. - Make the formatting example more like to the written text by adding an initial description. - An action's discover inputs runtime metrics is now categorized as parse time on the CriticalPathComponent. - Bazel's Debian package and the binary installer now include an improved wrapper that understands `<WORKSPACE>/.bazelversion` files and the `$USE_BAZEL_VERSION` environment variable. This is similar to what Bazelisk offers (https://github.com/bazelbuild/bazelisk#how-does-bazelisk-know-whi ch-bazel-version-to-run-and-where-to-get-it-from), except that it works offline and integrates with apt-get. - We are planning to deprecate the runfiles manifest files, which aren't safe in the presence of whitespace, and also unnecessarily require local CPU when remote execution is used. This release adds --experimental_skip_runfiles_manifests to disable the generation of the input manifests (rule.manifest files) in most cases. Note that this flag has no effect on Windows by default or if --experimental_enable_runfiles is explicitly set to false. This release contains contributions from many people at Google, as well as aldersondrive, Benjamin Peterson, Bor Kae Hwang, David Ostrovsky, Jakob Buchgraber, Jin, John Millikin, Keith Smiley, Lauri Peltonen, nikola-sh, Peter Mounce, Tony Hsu.

This is no longer supported in bazel 2: bazelbuild/bazel#6799

Baseline: 807ed23 Cherry picks: + db0e32c: build.sh: Fix bug in build script for RC release + 85e84f7: Set --incompatible_prohibit_aapt1 default to true. + 84eae2f: Let shellzelisk fallback to bazel-real if it's the requested version. + d5ae460: Fix a typo in bazel.sh Incompatible changes: - --incompatible_remap_main_repo is enabled by default. Therefore, both ways of addressing the main repository, by its name and by '@' are now considered referring to the same repository. see bazelbuild#7130 - --incompatible_disallow_dict_lookup_unhashable_keys is enabled by default bazelbuild#9184 - --incompatible_remove_native_maven_jar is now enabled by default and the flag removed. See bazelbuild#6799 - --incompatible_prohibit_aapt1 is enabled by default. See bazelbuild#10000 Important changes: - --incompatible_proto_output_v2: proto v2 for aquery proto output formats, which reduces the output size compared to v1. Note that the messages' ids in v2 are in uint64 instead of string like in v1. - Adds --incompatible_remove_enabled_toolchain_types. - Package loading now consistently fails if package loading had a glob evaluation that encountered a symlink cycle or symlink infinite expansion. Previously, such package loading with such glob evaluations would fail only in some cases. - The --disk_cache flag can now also be used together with the gRPC remote cache. - An action's discover inputs runtime metrics is now categorized as parse time on the CriticalPathComponent. - Make the formatting example more like to the written text by adding an initial description. - An action's discover inputs runtime metrics is now categorized as parse time on the CriticalPathComponent. - Bazel's Debian package and the binary installer now include an improved wrapper that understands `<WORKSPACE>/.bazelversion` files and the `$USE_BAZEL_VERSION` environment variable. This is similar to what Bazelisk offers (https://github.com/bazelbuild/bazelisk#how-does-bazelisk-know-whi ch-bazel-version-to-run-and-where-to-get-it-from), except that it works offline and integrates with apt-get. - We are planning to deprecate the runfiles manifest files, which aren't safe in the presence of whitespace, and also unnecessarily require local CPU when remote execution is used. This release adds --experimental_skip_runfiles_manifests to disable the generation of the input manifests (rule.manifest files) in most cases. Note that this flag has no effect on Windows by default or if --experimental_enable_runfiles is explicitly set to false. This release contains contributions from many people at Google, as well as aldersondrive, Benjamin Peterson, Bor Kae Hwang, David Ostrovsky, Jakob Buchgraber, Jin, John Millikin, Keith Smiley, Lauri Peltonen, nikola-sh, Peter Mounce, Tony Hsu.

Bazel 2.0 removes `maven_jar` from native rules. In order for us to migrate to newer Bazel, `checkstyle_dependencies` need to be adapted according to guide in bazelbuild/bazel#6799

See bazelbuild/bazel#6799 for more details

dkelmer added the incompatible-change Incompatible/breaking change label Nov 29, 2018

bazel-io pushed a commit that referenced this issue Nov 29, 2018

Add flag to control native maven jar rule deprecation.

21f4bd3

Closes #6768. Relevant to #6799. PiperOrigin-RevId: 223375698

dkelmer added the migration-ready label Nov 29, 2018

laurentlb added migration-0.21 and removed migration-ready labels Dec 14, 2018

meteorcloudy changed the title ~~--incompatible_remove_native_maven_jar~~ incompatible_remove_native_maven_jar Jan 2, 2019

meisterT added this to the Shrinking the bazel binary milestone Feb 3, 2019

dkelmer mentioned this issue Feb 6, 2019

Stop using native maven_jar rule bazelbuild/rules_appengine#96

Merged

dkelmer added a commit to dkelmer/rules_gwt that referenced this issue Feb 6, 2019

Stop using native maven_jar rule

8fb92c8

See bazelbuild/bazel#6799 for more details

dkelmer mentioned this issue Feb 6, 2019

Stop using native maven_jar rule bazelbuild/rules_gwt#20

Merged

dkelmer mentioned this issue Feb 6, 2019

Stop using native maven_jar rule in grpc grpc/grpc-java#5327

Merged

ekuefler pushed a commit to bazelbuild/rules_gwt that referenced this issue Feb 7, 2019

Stop using native maven_jar rule (#20)

c959552

See bazelbuild/bazel#6799 for more details

dkelmer self-assigned this Feb 7, 2019

dkelmer added a commit to dkelmer/android-testing that referenced this issue Feb 7, 2019

Stop using maven_jar in android-testing

d720149

See bazelbuild/bazel#6799 for more details

This was referenced Feb 7, 2019

Stop using maven_jar in android-testing android/testing-samples#245

Merged

Please stop using native.maven_jar bazelbuild/BUILD_file_generator#48

Open

meteorcloudy added the migration-0.22 label Feb 12, 2019

guw mentioned this issue Feb 15, 2019

Support Authentication in jvm_maven_import_external/java_import_external #7443

Closed

meisterT mentioned this issue Feb 21, 2019

Unbundle mobile tools #1055

Closed

meisterT mentioned this issue Feb 22, 2019

Remove dependency on the java.desktop module #7502

Closed

11 tasks

meisterT added migration-1.0 labels Oct 14, 2019

jin added breaking-change-2.0 P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Oct 15, 2019

jin mentioned this issue Oct 30, 2019

Add approved design document for maven_jar migration tool bazelbuild/proposals#148

Merged

philwo added the migration-1.2 label Nov 12, 2019

bazel-io closed this as completed in 489a9e5 Nov 14, 2019

chenrui333 mentioned this issue Nov 24, 2019

Deprecate maven_jar rule chenrui333/rules_openapi#23

Merged

laszlocsomor added a commit to laszlocsomor/rules_scala that referenced this issue Nov 28, 2019

Replace maven_jar with maven_install

ef06720

Context: bazelbuild/bazel#6799

laszlocsomor added a commit to laszlocsomor/rules_scala that referenced this issue Nov 28, 2019

Replace maven_jar with maven_install

2765a57

Context: bazelbuild/bazel#6799

laszlocsomor mentioned this issue Nov 28, 2019

WIP: Replace maven_jar with maven_install bazelbuild/rules_scala#887

Closed

scode added a commit to scode/bazelplay that referenced this issue Dec 28, 2019

Remove use of maven_jar.

94494f1

This is no longer supported in bazel 2: bazelbuild/bazel#6799

marplesoft mentioned this issue Mar 8, 2020

Support bazel 2.0 simuons/rules_clojure#4

Closed

vmax mentioned this issue Apr 13, 2020

Remove incompatible native.maven_jar usage typedb/typedb-dependencies#127

Merged

purvi-scio mentioned this issue Feb 22, 2023

Nullaway does not work with bazel uber/NullAway#737

Closed

mukundsrinivasb pushed a commit to mukundsrinivasb/espresso-testing-tuorial that referenced this issue Mar 31, 2023

Stop using maven_jar in android-testing

bcb1e74

See bazelbuild/bazel#6799 for more details

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

incompatible_remove_native_maven_jar #6799

incompatible_remove_native_maven_jar #6799

dkelmer commented Nov 29, 2018 •

edited by jin

Loading

meteorcloudy commented Jan 3, 2019

dkelmer commented Jan 16, 2019 •

edited

Loading

meisterT commented Feb 3, 2019

dkelmer commented Feb 6, 2019 •

edited

Loading

meteorcloudy commented Feb 12, 2019

guw commented Feb 15, 2019

dkelmer commented Feb 21, 2019

dapengzhang0 commented Mar 5, 2019

dkelmer commented Mar 5, 2019 •

edited

Loading

jin commented Sep 12, 2019

JLLeitschuh commented Sep 24, 2019

jin commented Oct 30, 2019 •

edited

Loading

JLLeitschuh commented Oct 31, 2019

jin commented Nov 14, 2019

incompatible_remove_native_maven_jar #6799

incompatible_remove_native_maven_jar #6799

Comments

dkelmer commented Nov 29, 2018 • edited by jin Loading

meteorcloudy commented Jan 3, 2019

dkelmer commented Jan 16, 2019 • edited Loading

meisterT commented Feb 3, 2019

dkelmer commented Feb 6, 2019 • edited Loading

meteorcloudy commented Feb 12, 2019

guw commented Feb 15, 2019

dkelmer commented Feb 21, 2019

dapengzhang0 commented Mar 5, 2019

dkelmer commented Mar 5, 2019 • edited Loading

jin commented Sep 12, 2019

JLLeitschuh commented Sep 24, 2019

jin commented Oct 30, 2019 • edited Loading

JLLeitschuh commented Oct 31, 2019

jin commented Nov 14, 2019

dkelmer commented Nov 29, 2018 •

edited by jin

Loading

dkelmer commented Jan 16, 2019 •

edited

Loading

dkelmer commented Feb 6, 2019 •

edited

Loading

dkelmer commented Mar 5, 2019 •

edited

Loading

jin commented Oct 30, 2019 •

edited

Loading