Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for the autodetecting toolchain's pywrapper script #7843

Closed
brandjon opened this issue Mar 26, 2019 · 0 comments
Closed

Add test for the autodetecting toolchain's pywrapper script #7843

brandjon opened this issue Mar 26, 2019 · 0 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Python Native rules for Python type: process

Comments

@brandjon
Copy link
Member

Probably a Python-based test, since it doesn't need to launch Bazel and therefore doesn't need to rely on any mock tools setup.
@brandjon brandjon added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: process team-Rules-Python Native rules for Python labels Mar 26, 2019
bazel-io pushed a commit that referenced this issue Mar 26, 2019
@brandjon @copybara-github
Implement autodetecting Python toolchain
2299445 
This replaces the stub default Python toolchain with one that actually locates the target platform's Python interpreter at runtime. Try it out with

    bazel build //some_py_binary --experimental_use_python_toolchains

and note that, unlike before (#4815), the correct Python interpreter gets invoked by default regardless of whether you specify `--python_version=PY2` or `--python_version=PY3`.

This toolchain is only intended as a last resort, if the user doesn't define and register a better toolchain (that satisfies the target platform constraints).

Work toward #7375 and #4815. Follow-up work needed to add a test (#7843) and windows support (#7844).

RELNOTES: None
PiperOrigin-RevId: 240417315
bazel-io pushed a commit that referenced this issue May 17, 2019
@brandjon @copybara-github
Remove stale TODO
868f8c9 
TODO was for #7843, which was already fixed.

RELNOTES: None
PiperOrigin-RevId: 248680773
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@brandjon @irengrig
Remove stale TODO
32b3d27 
TODO was for bazelbuild#7843, which was already fixed.

RELNOTES: None
PiperOrigin-RevId: 248680773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-Python Native rules for Python type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandjon