Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osx_archs uses arm for aarch64 #8520

Closed
steeve opened this issue May 30, 2019 · 2 comments
Closed

osx_archs uses arm for aarch64 #8520

steeve opened this issue May 30, 2019 · 2 comments
Assignees
@steeve @katre
Labels
P1 I'll work on this now. (Assignee required) type: bug z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple

Comments

@steeve
Copy link
Contributor

steeve commented May 30, 2019

Description of the problem / feature request:

osx_archs.bzl define arm64 as @bazel_tools//platforms:arm rather than @bazel_tools//platforms:aarch64.

See https://github.com/bazelbuild/bazel/blob/bc6f7cb330bb531f062bb301f3703876051191f5/tools/osx/crosstool/osx_archs.bzl (master as of now):

OSX_TOOLS_CONSTRAINTS = {
    "darwin_x86_64": ["@bazel_tools//platforms:osx", "@bazel_tools//platforms:x86_64"],
    "ios_i386": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:x86_32"],
    "ios_x86_64": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:x86_64"],
    "watchos_i386": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:x86_32"],
    "watchos_x86_64": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:x86_64"],
    "tvos_x86_64": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:x86_64"],
    "armeabi-v7a": ["@bazel_tools//platforms:arm"],
    "ios_armv7": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:arm"],
    "ios_arm64": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:arm"],
    "ios_arm64e": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:arm"],
    "watchos_armv7k": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:arm"],
    "watchos_arm64_32": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:arm"],
    "tvos_arm64": ["@bazel_tools//platforms:ios", "@bazel_tools//platforms:arm"],
}

Any other information, logs, or outputs that you want to share?

Some background info:
This was referenced May 30, 2019
Closed
Closed
Closed
@katre katre added P1 I'll work on this now. (Assignee required) z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple type: bug labels May 31, 2019
@katre
Copy link
Member

katre commented May 31, 2019

Thanks for identifying and fixing this!

@steeve
Copy link
Contributor Author

steeve commented May 31, 2019

I've opened #8522 !

aehlig pushed a commit that referenced this issue Jun 3, 2019
@steeve @aehlig
Fix ios, tvos and watchos arm64 constraints
af02251 
They were using the `:arm` constraint, which looks like a bug.

Fixes #8520

Closes #8522.

PiperOrigin-RevId: 250883517
aehlig pushed a commit that referenced this issue Jun 4, 2019
@steeve @aehlig
Fix ios, tvos and watchos arm64 constraints
d4e8b68 
They were using the `:arm` constraint, which looks like a bug.

Fixes #8520

Closes #8522.

PiperOrigin-RevId: 250883517
bazel-io pushed a commit that referenced this issue Jun 6, 2019
@aehlig
Release 0.26.1 (2019-06-06)
e6976fb 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- #8475
- #8520
- bazelbuild/intellij#845
AlessandroPatti pushed a commit to uber-common/bazel that referenced this issue Jun 6, 2019
@aehlig
Release 0.26.1 (2019-06-06)
cfc6800 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- bazelbuild#8475
- bazelbuild#8520
- bazelbuild/intellij#845
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@steeve @irengrig
Fix ios, tvos and watchos arm64 constraints
ac74dca 
They were using the `:arm` constraint, which looks like a bug.

Fixes bazelbuild#8520

Closes bazelbuild#8522.

PiperOrigin-RevId: 250883517
irengrig pushed a commit to irengrig/bazel that referenced this issue Jun 18, 2019
@irengrig
Release 0.26.1 (2019-06-06)
6f5cae4 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- bazelbuild#8475
- bazelbuild#8520
- bazelbuild/intellij#845
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@steeve @irengrig
Fix ios, tvos and watchos arm64 constraints
06011ff 
They were using the `:arm` constraint, which looks like a bug.

Fixes bazelbuild#8520

Closes bazelbuild#8522.

PiperOrigin-RevId: 250883517
irengrig pushed a commit to irengrig/bazel that referenced this issue Jul 15, 2019
@irengrig
Release 0.26.1 (2019-06-06)
5d5105d 
Baseline: c2001a4

Cherry picks:

   + e67c961:
     Fix a non-determinism in create_embedded_tools.py.
   + 81aefe7:
     Remove unsupported cpu attribute from cc_toolchains.
   + 597e289:
     remote: made CombinedCache a composition of Disk and Http Cache
   + 942f7cf:
     C++: Fixes bug in C++ API with external repo aspects
   + 85a5a2b:
     Configure @androidsdk//:emulator_x86 and :emulator_arm to point
     to the unified emulator binary
   + 9835cb4:
     Automated rollback of commit
     844e4e2.
   + c963ba2:
     Windows, Python: fix arg. esc. also in host config
   + a1ea487:
     Do not pre-cache changed files under managed directories
   + 7dc78cd:
     Add explicit execution and target constraints for autodiscovered
     cc t?
   + dd9ac13:
     Fix a bug when a relative path is used for the execution log
   + 0ff19c6:
     Fix StandaloneTestStrategy.appendStderr
   + 7f49531:
     Fix the autodetecting Python toolchain on Mac
   + ddce723:
     Avoid exporting PATH unnecessarily
   + 35dd05a:
     Allow Starlark rules to be able to use the `exec_compatible_with`
   + cb82ed8:
     Release 0.26.0 (2019-05-28)
   + d1c0d20:
     Allow WORKSPACE file to be a symlink if no managed directories
     is used.
   + c3d2aa7:
     Fix ios, tvos and watchos arm64 constraints
   + 55e4205:
     Bump java_tools_javac10 from 3.1 to 3.2

Patch release on top of 0.26.0, fixing
- bazelbuild#8475
- bazelbuild#8520
- bazelbuild/intellij#845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steeve steeve

@katre katre

Labels
P1 I'll work on this now. (Assignee required) type: bug z-team-Apple Deprecated. Send to rules_apple, or label team-Rules-CPP + platform:apple
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ios, tvos and watchos arm64 constraints
2 participants
@steeve @katre