Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up @bazel_tools #8859

Closed
laszlocsomor opened this issue Jul 11, 2019 · 1 comment
Closed

Clean up @bazel_tools #8859

laszlocsomor opened this issue Jul 11, 2019 · 1 comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request:

This is an umbrella issue to track efforts to clean up @bazel_tools. We should remove unnecessary source code from this repo, and make it work for bazel query @bazel_tools//....

Details

This repo is built into Bazel. It's always available in every workspace. It's a place for commonly used tools like tools/test/test-setup.sh, which is the test wrapper used for every bazel test action.

But there is also source code in this repo, each file for their own reason. E.g. the runfiles libraries @bazel_tools//tools/<lang>/runfiles are included as source so they can be compiled into binaries.

Some source code's purpose in @bazel_tools is less obvious. Sometimes they cause problems, like #8614 whose culprit is #8742 (comment).

What's the output of bazel info release?

release 0.28.0

@aiuto aiuto added team-Bazel General Bazel product/strategy issues P2 We'll consider working on this in future. (Assignee optional) type: process labels Jul 11, 2019
@dslomov dslomov added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website and removed team-Bazel General Bazel product/strategy issues labels Jul 19, 2019
@philwo philwo added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Jul 29, 2019
bazel-io pushed a commit that referenced this issue Aug 29, 2019
This target globs all bzl files under @bazel_tools//tools under a single filegroup.

Progress toward #8859
Should fix bazelbuild/skydoc#185 when we introduce a bzl_library target in bazel_skylib to point to this new target.

RELNOTES: None.
PiperOrigin-RevId: 266219278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Development

No branches or pull requests

5 participants
@philwo @aiuto @dslomov @laszlocsomor and others