Add s390x and make zip -d step more resilient #10798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwo
suggested changes
Feb 17, 2020
third_party/BUILD
Outdated
Comment on lines
472
to
473
| "//src/conditions:freebsd": "*.so *.jnilib *.dll", | ||
| "//src/conditions:openbsd": "*.so *.jnilib *.dll", |
There was a problem hiding this comment.
Um... because despite all my efforts not to I managed to overlook something when I ran the push? I’ll un-remove them now...
There was a problem hiding this comment.
@philwo Patched up.
philwo
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #10643 for application to third_party directory
Build on s390x fails because the process to remove unnecessary libraries from netty was not configured for x86. As a result, zip -d failed because it had nothing to remove. This PR does two things:
See also Issue #9263; Pull Requests #9346 and #9945