Explicitly state that embedding macOS OpenJDK is for x86_64 #12620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows adding additional macOS OpenJDK that targets arm64 arch later.
jin
added
area-EngProd
thii
deleted the
explicitly-state-that-embedding-macos-openjdk-is-for-x86_64
branch
meteorcloudy
pushed a commit
that referenced
this pull request
Apr 20, 2021
This allows adding additional macOS OpenJDK that targets arm64 arch later. Closes #12620. PiperOrigin-RevId: 346138763
philwo
pushed a commit
that referenced
this pull request
Apr 20, 2021
This allows adding additional macOS OpenJDK that targets arm64 arch later. Closes #12620. PiperOrigin-RevId: 346138763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows adding additional macOS OpenJDK that targets arm64 arch
later.