Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host_per_file_copt and host_per_file_ltobackendopt build options #12833

Closed

Conversation

bjacklyn
Copy link

Implementation for #12406

@bjacklyn bjacklyn requested a review from lberki as a code owner January 15, 2021 02:27
@google-cla
Copy link

google-cla bot commented Jan 15, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 15, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 15, 2021
@jin jin added the team-Rules-CPP Issues for C++ rules label Jan 15, 2021
@jin
Copy link
Member

jin commented Jan 15, 2021

cc @oquenchil

@lberki lberki requested review from oquenchil and removed request for lberki January 15, 2021 07:56
@oquenchil oquenchil self-assigned this Jan 15, 2021
@alexkaratarakis
Copy link

Is there an issue that prevents merging this? I was about to open a new issue about this but found this PR instead.

@oquenchil
Copy link
Contributor

You can use different toolchains for target and host. You can have features enabled in one but not the other. Maybe this PR fits into the theme of improving the extensibility of crosstools. Any solution to #12406 should probably tackle it from this direction. I will close this PR.

@oquenchil oquenchil closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants