Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ijar failing on empty jars. #12893

Closed
wants to merge 4 commits into from
Closed

Fix ijar failing on empty jars. #12893

wants to merge 4 commits into from

Commits on Jan 25, 2021

  1. Fix ijar failing on empty jars. 

    The problem happens when all the files are filtered out. In such case a dummy file is created, but not accounted for in the size estimation.
Fixes bazelbuild#10162
    @comius
    comius committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    952c34f View commit details
    Browse the repository at this point in the history

  2. Remove use of std:max function (fails on mac and windows)

    @comius
    comius committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    15e5583 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Add test.

    @comius
    comius committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    88ead7b View commit details
    Browse the repository at this point in the history

  2. Fix constant.

    @comius
    comius committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    da6f27b View commit details
    Browse the repository at this point in the history