-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/3] Bump grpc to 1.33.1 to fix corruption when downloading CAS blobs #13106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the jar files are appeared as moved instead of deleted then added?
I think it's a github UI glitch. Git shows that the files are changing:
|
1840cfc
to
33ac15d
Compare
OK, thanks! |
FYI @coeuvre |
@scele Thank you for the PR series! I think this would be ready to merge, now that the other two are in. Could you please rebase this, so that we can get a clean CI run before merging it? |
Part 3: remove 1.32.x from third_party/grpc. grpc-java versions 1.27 through 1.32 had a bug where messages could arrive after the call was reported clsoed. In the case of bazel, this meant that in GrpcCacheClient, onNext could be called after onError. This leads to offset bookkeeping getting out of sync, and corrupts the CAS blob download. bazelbuild#12927
33ac15d
to
77e7661
Compare
@meteorcloudy @philwo rebased! |
Thanks, merging this now! |
Thank you so much! Now merged! |
Part 3: remove 1.32.x from third_party/grpc. grpc-java versions 1.27 through 1.32 had a bug where messages could arrive after the call was reported clsoed. In the case of bazel, this meant that in GrpcCacheClient, onNext could be called after onError. This leads to offset bookkeeping getting out of sync, and corrupts the CAS blob download. #12927 Closes: #13106
Part 3: remove 1.32.x from third_party/grpc. grpc-java versions 1.27 through 1.32 had a bug where messages could arrive after the call was reported clsoed. In the case of bazel, this meant that in GrpcCacheClient, onNext could be called after onError. This leads to offset bookkeeping getting out of sync, and corrupts the CAS blob download. #12927 Closes: #13106
Part 3: remove 1.32.x from third_party/grpc. grpc-java versions 1.27 through 1.32 had a bug where messages could arrive after the call was reported clsoed. In the case of bazel, this meant that in GrpcCacheClient, onNext could be called after onError. This leads to offset bookkeeping getting out of sync, and corrupts the CAS blob download. bazelbuild#12927 Closes: bazelbuild#13106
Part 3: remove 1.32.x from third_party/grpc.
grpc-java versions 1.27 through 1.32 had a bug where messages could arrive
after the call was reported clsoed. In the case of bazel, this meant that
in GrpcCacheClient, onNext could be called after onError. This leads to
offset bookkeeping getting out of sync, and corrupts the CAS blob download.
#12927