Use xcrun to invoke install_name_tool
#13462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
reviewed
May 11, 2021
tools/cpp/osx_cc_wrapper.sh.tpl
Outdated
| @@ -110,7 +110,7 @@ for rpath in ${RPATHS}; do | |||
| if [[ -n "${libname-}" ]]; then | |||
| libpath=$(get_library_path ${lib}) | |||
| if [ -n "${libpath}" ]; then | |||
| ${INSTALL_NAME_TOOL} -change $(get_otool_path "${libpath}") \ | |||
| "${INSTALL_NAME_TOOL}" -change $(get_otool_path "${libpath}") \ | |||
There was a problem hiding this comment.
Maybe just in-line this? With this currently I think your quotes are off?
thii
force-pushed
the
use-xcrun-to-invoke-install_name_tool
branch
from
5fe632b
to
2af0989
Compare
keith
reviewed
Feb 22, 2022
tools/cpp/osx_cc_wrapper.sh.tpl
Outdated
| @@ -27,7 +27,7 @@ | |||
| # | |||
| set -eu | |||
|
|
|||
| INSTALL_NAME_TOOL="/usr/bin/install_name_tool" | |||
| INSTALL_NAME_TOOL="/usr/bin/xcrun install_name_tool" | |||
There was a problem hiding this comment.
i think it would be better to inline this now that it has a space to be more careful around folks accidentally quoting this
`/usr/bin/install_name_tool` is a shim; it invokes `install_name_tool` in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool.
thii
force-pushed
the
use-xcrun-to-invoke-install_name_tool
branch
from
2af0989
to
3a867bd
Compare
|
Hi there! Thank you for contributing to the Bazel repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so. |
Wyverald
pushed a commit
that referenced
this pull request
Jan 12, 2023
`/usr/bin/install_name_tool` is a shim; it invokes install_name_tool in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool. replaces #13462 Closes #16951. PiperOrigin-RevId: 501557408 Change-Id: Ibf0b90aaf18bd703079296248cd66dc6f86359f1
ShreeM01
added a commit
that referenced
this pull request
Jan 19, 2023
`/usr/bin/install_name_tool` is a shim; it invokes install_name_tool in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool. replaces #13462 Closes #16951. PiperOrigin-RevId: 501557408 Change-Id: Ibf0b90aaf18bd703079296248cd66dc6f86359f1 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
`/usr/bin/install_name_tool` is a shim; it invokes install_name_tool in the current active Xcode. This allows using this template file to configure toolchain on non-macOS. This doesn't change the behavior as both will end up invoking the same tool. replaces #13462 Closes #16951. PiperOrigin-RevId: 501557408 Change-Id: Ibf0b90aaf18bd703079296248cd66dc6f86359f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin/install_name_toolis a shim; it invokesinstall_name_toolin the current active Xcode.
This allows using this template file to configure toolchain on
non-macOS. This doesn't change the behavior as both will end up invoking
the same tool.