Remote: Update BEP uploader to use RemoteCache and more robust to upload errors #13959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwo
reviewed
Sep 9, 2021
| @@ -619,6 +616,16 @@ public void beforeCommand(CommandEnvironment env) throws AbruptExitException { | |||
| executorService, env, remoteCache, retryScheduler, digestUtil); | |||
| } | |||
|
|
|||
| buildEventArtifactUploaderFactoryDelegate.init( | |||
There was a problem hiding this comment.
Should we use a buildEventArtifactUploaderFactoryDelegateAdapterFacade.init() here instead? (just kidding ;))
gregestren
added
the
team-Remote-Exec
|
Does this mean BES uploading will respect |
|
Not yet. I will create another PR for that. |
|
Would this commit merged into bazel-4.x version? |
|
Unfortunately no since this commit is based on many other improvement we made for remote execution after 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local files referenced by build events are uploaded to remote cache with
ByteStreamBuildEventArtifactUploaderwhich usesByteStreamUploaderandMissingDigestsFinderinternally.This PR changes
ByteStreamBuildEventArtifactUploaderto useRemoteCachedirectly in order to benefit from recently improvements toRemoteCache.Upload error that used to crash Bazel or cause a non-zero exit code is now caught and reported.
Fixes #13920.
Related #11473.