Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't resolve symlinks for --sandbox_base #13984

Closed
wants to merge 1 commit into from
Closed

Don't resolve symlinks for --sandbox_base #13984

wants to merge 1 commit into from

Commits on Jan 10, 2022

  1. Don't resolve symlinks for --sandbox_base 

    On macOS BigSur, the sandbox-exec command behaves slightly different than on
Catalina when firm links are present.

Resolving symlinks can prevent the sandbox for allowing write operations to the
sandbox base.

This effectively reverts a piece of 656a0ba on macOS, namely:

>  When using --experimental_sandbox_base, ensure that symlinks in the path are
>  resolved. Before this, you had to check whether on your system /dev/shm is a
>  symlink to /run/shm and then use that instead. Now it no longer matters, as
>  symlinks are resolved.

but I think this is okay since macOS doesn't have /dev/shm or /run.

See bazelbuild#13766 for full details.
    @ob
    ob committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    a82022f View commit details
    Browse the repository at this point in the history