Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UrlRewriter should be able to load credentials from .netrc #14066

Closed
wants to merge 5 commits into from
Closed

UrlRewriter should be able to load credentials from .netrc #14066

wants to merge 5 commits into from

Conversation

denyska
Copy link
Contributor

@denyska denyska commented Oct 1, 2021

Addresses #13111

@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@denyska denyska force-pushed the respect_netrc_url_rewrite branch 7 times, most recently from c157592 to 7012265 Compare October 1, 2021 02:43
@denyska
Copy link
Contributor Author

denyska commented Nov 19, 2021

Hi @coeuvre , any comments?

@aiuto aiuto assigned meteorcloudy and unassigned coeuvre Dec 18, 2021
@aiuto aiuto added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. and removed cla: yes labels Dec 18, 2021
@denyska
Copy link
Contributor Author

denyska commented Jan 26, 2022

thnx for reviewing, @meteorcloudy . Please take another look

@bazel-io bazel-io closed this in 1e53b1f Jan 28, 2022
@Bencodes
Copy link
Contributor

Bencodes commented Feb 1, 2022

Would be great to get this cherry picked into the 5.1 release. https://github.com/bazelbuild/bazel/milestone/35

@Wyverald Wyverald added this to the 5.1 release blockers milestone Feb 1, 2022
@Wyverald Wyverald mentioned this pull request Feb 3, 2022
Closed
@Wyverald
Copy link
Member

Wyverald commented Feb 3, 2022

needs to be cherry-picked into 5.1: #14710

@Wyverald Wyverald removed this from the 5.1 release blockers milestone Feb 3, 2022
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Feb 16, 2022
@brentleyjones
UrlRewriter should be able to load credentials from .netrc
7f999ff 
Addresses bazelbuild#13111

Closes bazelbuild#14066.

PiperOrigin-RevId: 424854105
(cherry picked from commit 1e53b1f)
Wyverald pushed a commit that referenced this pull request Feb 16, 2022
@brentleyjones
UrlRewriter should be able to load credentials from .netrc (#14834)
6990c02 
Addresses #13111

Closes #14066.

PiperOrigin-RevId: 424854105
(cherry picked from commit 1e53b1f)

Co-authored-by: Denys Kurylenko <denyska@fast.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees

@meteorcloudy meteorcloudy

Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@denyska @Bencodes @Wyverald @meteorcloudy @aiuto @coeuvre