Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support select() on constraint_value for aliases. #14310

Closed
wants to merge 3 commits into from
Closed

Support select() on constraint_value for aliases. #14310

wants to merge 3 commits into from

Commits on Nov 23, 2021

  1. Support select() on constraint_value for aliases. 

    This implements approach bazelbuild#4 of
bazelbuild#13047 (comment).

The basic change adds a new toolchain resolution mode: "resolve iff the target
has a select()". It then sets alias() to that mode.

We could remove this special casing if we ever ubiquitously provide platfrom
info to *all* rules
(bazelbuild#12899 (comment)).

RELNOTES: alias() can now select() directly on constraint_value()

Fixes bazelbuild#13047.

PiperOrigin-RevId: 411684872
Change-Id: I998ef9bba3226871651fc14bd9ed268e9a3de82c
    @gregestren
    gregestren committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    2f5048d View commit details
    Browse the repository at this point in the history

  2. Update cquery test to account for new toolchain deps.

    @gregestren
    gregestren committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    e51aede View commit details
    Browse the repository at this point in the history

  3. Update comments for review feedback

    @gregestren
    gregestren committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    e86e22f View commit details
    Browse the repository at this point in the history