Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Label instances as keys in select #14447

Closed
wants to merge 1 commit into from
Closed

Allow Label instances as keys in select #14447

wants to merge 1 commit into from

Commits on Dec 19, 2021

  1. Allow Label instances as keys in select 

    When a macro specifies a label string as a key in a select, this label
is resolved relative to the site of use rather than the .bzl file the
macro is defined in. The resolution will lead to incorrect results if
the repository that uses the macro has a different repo mapping, e.g.
because it is created by another Bazel module.

This can be solved by allowing macros to specify label instances created
with the `Label` constructor instead of label strings everywhere, which
previously was not possible in select.

This commit also updates the docs for Label, select and macros.

Fixes bazelbuild#14259.
    @fmeum
    fmeum committed Dec 19, 2021
    Configuration menu
    Copy the full SHA
    d299a87 View commit details
    Browse the repository at this point in the history