Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ctx.fragments.apple.single_arch_cpu returning incorrect cpu for tools when host cpu and exec cpu are different #14665

Closed
wants to merge 1 commit into from
Closed

Fix ctx.fragments.apple.single_arch_cpu returning incorrect cpu for tools when host cpu and exec cpu are different #14665

wants to merge 1 commit into from

Conversation

thii
Copy link
Member

@thii thii commented Jan 28, 2022 •
edited
Loading

Fixes #14291

@thii thii force-pushed the fix-ctx.fragments.apple.single_arch_cpu-returning-incorrect-cpu-for branch from 76f373a to 9bf3d7d Compare January 29, 2022 23:48
@thii
Fix ctx.fragments.apple.single_arch_cpu returning incorrect cpu for
b399a17 
tools when host cpu and exec cpu are different
@thii thii force-pushed the fix-ctx.fragments.apple.single_arch_cpu-returning-incorrect-cpu-for branch from 9bf3d7d to b399a17 Compare January 30, 2022 00:20
@thii thii marked this pull request as ready for review January 30, 2022 01:04
@thii thii requested a review from lberki as a code owner January 30, 2022 01:04
@thii thii mentioned this pull request Jan 31, 2022
Closed
@gregestren
Copy link
Contributor

@keith @brentleyjones are you comfortable reviewing PRs like this (especially given pending OWNERS updates)? Or do you recommend elsewhere?

@keith
Copy link
Member

keith commented Feb 1, 2022

Yes, also in this case @katre since you investigated this issue as well maybe you have some thoughts?

katre
katre approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll import this and get it in front of the internal experts today.

@bazel-io bazel-io closed this in fce7ea8 Feb 2, 2022
@thii thii deleted the fix-ctx.fragments.apple.single_arch_cpu-returning-incorrect-cpu-for branch February 2, 2022 19:18
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Feb 8, 2022
@thii @brentleyjones
Fix ctx.fragments.apple.single_arch_cpu returning incorrect cpu for…
5565f99 
… tools when host cpu and exec cpu are different

Fixes bazelbuild#14291

Closes bazelbuild#14665.

PiperOrigin-RevId: 425886938
(cherry picked from commit fce7ea8)
Wyverald pushed a commit that referenced this pull request Feb 9, 2022
@brentleyjones @thii
Fix ctx.fragments.apple.single_arch_cpu returning incorrect cpu for…
21ff46a 
… tools when host cpu and exec cpu are different (#14751)

Fixes #14291

Closes #14665.

PiperOrigin-RevId: 425886938
(cherry picked from commit fce7ea8)

Co-authored-by: Thi Doan <t@thi.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keith keith keith approved these changes

@katre katre katre approved these changes

@lberki lberki Awaiting requested review from lberki lberki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ctx.fragments.apple.single_arch_cpu returns wrong cpu of execution platform
4 participants
@thii @gregestren @keith @katre