Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote: Don't check TreeArtifact output #15077

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,13 @@ public InMemoryOutput downloadOutputs(RemoteAction action, RemoteActionResult re
// Check that all mandatory outputs are created.
for (ActionInput output : action.spawn.getOutputFiles()) {
if (action.spawn.isMandatoryOutput(output)) {
// Don't check output that is tree artifact since spawn could generate nothing under that
// directory. Remote server typically doesn't create directory ahead of time resulting in
// empty tree artifact missing from action cache entry.
if (output instanceof Artifact && ((Artifact) output).isTreeArtifact()) {
continue;
}

Path localPath = execRoot.getRelative(output.getExecPath());
if (!metadata.files.containsKey(localPath)
&& !metadata.directories.containsKey(localPath)
Expand Down
57 changes: 57 additions & 0 deletions src/test/shell/bazel/remote/remote_execution_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,63 @@ EOF
|| fail "Failed to run //a:starlark_output_dir_test with remote execution"
}

function generate_empty_treeartifact_build() {
mkdir -p a
cat > a/BUILD <<'EOF'
load(":output_dir.bzl", "gen_output_dir")
gen_output_dir(
name = "output-dir",
outdir = "dir",
)
EOF
cat > a/output_dir.bzl <<'EOF'
def _gen_output_dir_impl(ctx):
output_dir = ctx.actions.declare_directory(ctx.attr.outdir)
ctx.actions.run_shell(
outputs = [output_dir],
inputs = [],
command = "",
arguments = [output_dir.path],
)
return [
DefaultInfo(files = depset(direct = [output_dir])),
]

gen_output_dir = rule(
implementation = _gen_output_dir_impl,
attrs = {
"outdir": attr.string(mandatory = True),
},
)
EOF
}

function test_empty_treeartifact_works_with_remote_execution() {
# Test that empty tree artifact works with remote execution
generate_empty_treeartifact_build

bazel build \
--remote_executor=grpc://localhost:${worker_port} \
//a:output-dir >& $TEST_log || fail "Failed to build"
}

function test_empty_treeartifact_works_with_remote_cache() {
# Test that empty tree artifact works with remote cache
generate_empty_treeartifact_build

bazel build \
--remote_cache=grpc://localhost:${worker_port} \
//a:output-dir >& $TEST_log || fail "Failed to build"

bazel clean

bazel build \
--remote_cache=grpc://localhost:${worker_port} \
//a:output-dir >& $TEST_log || fail "Failed to build"

expect_log "remote cache hit"
}

function test_downloads_minimal() {
# Test that genrule outputs are not downloaded when using
# --remote_download_minimal
Expand Down