Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android emulator darwin_arm64 select #15092

Conversation

keith
Copy link
Member

@keith keith commented Mar 21, 2022

This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
bazelbuild#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs
@ckolli5 ckolli5 added the team-Android Issues for Android team label Mar 22, 2022
@ted-xie
Copy link
Contributor

ted-xie commented Apr 25, 2022

Hi Keith,

Thank you for this PR! At a glance it looks pretty low-risk. It looks like this is related to compiling Android projects on M1 Macs. Do you know how we could validate this fix on our own M1 machines, and have you done the same test on your own machine? What bug did this PR solve? In general, some more documentation around the select would be helpful context for maintainers.

@keith
Copy link
Member Author

keith commented Apr 25, 2022

Trying to run an emulator test on macOS will first fail with this:

ERROR: /private/var/tmp/_bazel_snowp/5f415e59f25252568cd030dfdb79d872/external/android_test_support/tools/android/emulated_devices/generic_phone/BUILD.bazel:43:12: Creating Android image for @android_test_support//tools/android/emulated_devices/generic_phone:android_28_x86 failed: missing input file 'external/androidsdk/emulator/qemu/darwin-x86_64/qemu-system-i386', owner: '@androidsdk//:emulator/qemu/darwin-x86_64/qemu-system-i386'

As I mentioned this doesn't make these tests fully work, but this error looked more like an infrastructure error than a behavior limitation to the person who hit it here, which confused them into thinking it was just a misconfiguration.

@ted-xie
Copy link
Contributor

ted-xie commented Apr 25, 2022

Thanks for the background. Overall looks good to me; I'll start importing this and let you know if there are any show stoppers.

@bazel-io bazel-io closed this in 73f1ecb Apr 27, 2022
@keith keith deleted the ks/fix-android-emulator-darwin_arm64-select branch April 27, 2022 18:08
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2022
@ckolli5
Copy link

ckolli5 commented Apr 27, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2022
ckolli5 added a commit that referenced this pull request May 10, 2022
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
meteorcloudy pushed a commit that referenced this pull request May 10, 2022
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs

Closes #15092.

PiperOrigin-RevId: 444912275

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants