-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android emulator darwin_arm64 select #15092
Fix android emulator darwin_arm64 select #15092
Conversation
This fixes this condition printing a strange error if you try to run these on macOS. In general this still doesn't work because of bazelbuild#7069 but if we ever want to support it this is a pre-requisite to supporting arm macs
Hi Keith, Thank you for this PR! At a glance it looks pretty low-risk. It looks like this is related to compiling Android projects on M1 Macs. Do you know how we could validate this fix on our own M1 machines, and have you done the same test on your own machine? What bug did this PR solve? In general, some more documentation around the select would be helpful context for maintainers. |
Trying to run an emulator test on macOS will first fail with this:
As I mentioned this doesn't make these tests fully work, but this error looked more like an infrastructure error than a behavior limitation to the person who hit it here, which confused them into thinking it was just a misconfiguration. |
Thanks for the background. Overall looks good to me; I'll start importing this and let you know if there are any show stoppers. |
@bazel-io flag |
@bazel-io fork 5.2.0 |
This fixes this condition printing a strange error if you try to run these on macOS. In general this still doesn't work because of #7069 but if we ever want to support it this is a pre-requisite to supporting arm macs Closes #15092. PiperOrigin-RevId: 444912275 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
This fixes this condition printing a strange error if you try to run these on macOS. In general this still doesn't work because of #7069 but if we ever want to support it this is a pre-requisite to supporting arm macs Closes #15092. PiperOrigin-RevId: 444912275 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
This fixes this condition printing a strange error if you try to run
these on macOS. In general this still doesn't work because of
#7069 but if we ever want to
support it this is a pre-requisite to supporting arm macs