Remote: Don't check declared outputs for failed action #15151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
added a commit
to keith/envoy
that referenced
this pull request
Mar 31, 2022
This avoids this issue envoyproxy#20599 and I do not believe we were hit by the original issue that introduced this regression. There is a fix in bazelbuild/bazel#15151 that should get us past this in bazel 5.2+. It seems this warning was just a red herring and actually meant your actions failed. This reverts commit fd92486. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
added a commit
to envoyproxy/envoy
that referenced
this pull request
Mar 31, 2022
This avoids this issue #20599 and I do not believe we were hit by the original issue that introduced this regression. There is a fix in bazelbuild/bazel#15151 that should get us past this in bazel 5.2+. It seems this warning was just a red herring and actually meant your actions failed. This reverts commit fd92486. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
@bazel-io fork 5.2 |
|
@bazel-io fork 5.1.1 |
Wyverald
pushed a commit
to Wyverald/bazel
that referenced
this pull request
Apr 5, 2022
Fix a bug that Bazel print message ``` Invalid action cache entry ...: expected output ... does not exist. ``` instead of the underlying error message when remote action failed. Closes bazelbuild#15151. PiperOrigin-RevId: 438815494
Wyverald
added a commit
that referenced
this pull request
Apr 5, 2022
Fix a bug that Bazel print message ``` Invalid action cache entry ...: expected output ... does not exist. ``` instead of the underlying error message when remote action failed. Closes #15151. PiperOrigin-RevId: 438815494 Co-authored-by: Chi Wang <chiwang@google.com>
oliviernotteghem
pushed a commit
to oliviernotteghem/bazel
that referenced
this pull request
Apr 27, 2022
Fix a bug that Bazel print message ``` Invalid action cache entry ...: expected output ... does not exist. ``` instead of the underlying error message when remote action failed. Closes bazelbuild#15151. PiperOrigin-RevId: 438815494
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
This avoids this issue envoyproxy#20599 and I do not believe we were hit by the original issue that introduced this regression. There is a fix in bazelbuild/bazel#15151 that should get us past this in bazel 5.2+. It seems this warning was just a red herring and actually meant your actions failed. This reverts commit fd92486. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
I'm still seeing this behavior in 5.2.0, 5.1.1, and 6.0.0-pre.20220608.2. If I go back to 5.0.0, the error messages work fine. I'm compiling C++ code, FWIW |
|
I think I figured out my problem. I had an unintentional After fixing that, Bazel 5.2.0 works as expected. |
|
I see. This check was implemented to intentionally avoid that issue, see #14543. |
|
Created #15724, with that, the error message will still be printed in this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that Bazel print message
instead of the underlying error message when remote action failed.