Remote: Fix a bug that outputs of actions tagged with no-remote are u… #15212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ploaded to remote cache when remote execution is enabled.
tjgq
reviewed
Apr 12, 2022
| } | ||
|
|
||
| /** Returns the {@link Type} of the context. */ | ||
| Type getType(); | ||
| private final Spawn spawn; |
tjgq
reviewed
Apr 12, 2022
| private Step step; | ||
|
|
||
| public RemoteActionExecutionContext( | ||
| Spawn spawn, RequestMetadata requestMetadata, NetworkTime networkTime) { |
There was a problem hiding this comment.
Also - should we make the ctor private to enforce construction through one of the create() methods?
tjgq
reviewed
Apr 12, 2022
| @@ -258,7 +259,7 @@ static Command buildCommand( | |||
| public static class RemoteAction { | |||
| private final Spawn spawn; | |||
| private final SpawnExecutionContext spawnExecutionContext; | |||
| private final RemoteActionExecutionContext remoteActionExecutionContext; | |||
| private final RemoteActionExecutionContext context; | |||
There was a problem hiding this comment.
Is it a good idea to rename this, given that there are two different context objects?
There was a problem hiding this comment.
Yes. Revert the rename. Extracted RemoteAction to an upper level.
tjgq
approved these changes
Apr 12, 2022
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
May 10, 2022
...ploaded to remote cache when remote execution is enabled. Fixes bazelbuild#14900. Also fixes an issue that action result from just remotely executed action is not saved to disk cache. The root cause is the action result is inlined in the execution response hence not downloaded through remote cache, hence not saved to disk cache. This results in the second build misses the disk cache, but it can still hit the remote cache and fill the disk cache. The third build can hit disk cache. Closes bazelbuild#15212. PiperOrigin-RevId: 441426469
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
May 27, 2022
…ploaded to remote cache when remote execution is enabled. Fixes bazelbuild#14900. Also fixes an issue that action result from just remotely executed action is not saved to disk cache. The root cause is the action result is inlined in the execution response hence not downloaded through remote cache, hence not saved to disk cache. This results in the second build misses the disk cache, but it can still hit the remote cache and fill the disk cache. The third build can hit disk cache. Closes bazelbuild#15212. PiperOrigin-RevId: 441426469
ckolli5
added a commit
that referenced
this pull request
May 27, 2022
… are u... (#15453) * Remote: Fix a bug that outputs of actions tagged with no-remote are u… …ploaded to remote cache when remote execution is enabled. Fixes #14900. Also fixes an issue that action result from just remotely executed action is not saved to disk cache. The root cause is the action result is inlined in the execution response hence not downloaded through remote cache, hence not saved to disk cache. This results in the second build misses the disk cache, but it can still hit the remote cache and fill the disk cache. The third build can hit disk cache. Closes #15212. PiperOrigin-RevId: 441426469 * Fix test Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ploaded to remote cache when remote execution is enabled.
Fixes #14900.
Also fixes an issue that action result from just remotely executed action is not saved to disk cache. The root cause is the action result is inlined in the execution response hence not downloaded through remote cache, hence not saved to disk cache. This results in the second build misses the disk cache, but it can still hit the remote cache and fill the disk cache. The third build can hit disk cache.