Record additional profiling information for remotely executed actions. #15348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Remote-Exec
meisterT
reviewed
Apr 27, 2022
It's the bits under "execute remotely".
|
meisterT
reviewed
Apr 27, 2022
|
|
||
| logProfileTask(converter, executedActionMetadata.getQueuedTimestamp(), | ||
| executedActionMetadata.getWorkerStartTimestamp(), | ||
| REMOTE_QUEUE, "Remote execution queuing time"); |
There was a problem hiding this comment.
Consider using just REMOTE_QUEUE.toString() here (and similar below) instead of the full description. I think that the enum names are still easy to read for humans and much shorter, so you don't see abbreviations like Remote execu... like you do now.
There was a problem hiding this comment.
Also consider removing Remote ... prefix as they are all under execute remotely span.
coeuvre
approved these changes
Apr 27, 2022
|
|
||
| logProfileTask(converter, executedActionMetadata.getQueuedTimestamp(), | ||
| executedActionMetadata.getWorkerStartTimestamp(), | ||
| REMOTE_QUEUE, "Remote execution queuing time"); |
There was a problem hiding this comment.
Also consider removing Remote ... prefix as they are all under execute remotely span.
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.2.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.