Replace uses of cfg = "host" with cfg = "exec"
#15785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This increases the compatibility for builds where host and exec platform are different (e.g., with remote execution).
|
@bazel-io flag (not a hard blocker for 5.3, but users can't test whether they are compatible with |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
|
@gregestren @comius Can you help review this one? |
|
AFAIK, this is all fine. |
katre
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Because cfg = "host" is treated identically to cfg = "exec", this change is effectively a no-op but makes the correct usage much more clear.
katre
added
awaiting-PR-merge
ckolli5
pushed a commit
to ckolli5/bazel
that referenced
this pull request
Jul 19, 2022
This increases the compatibility for builds where host and exec platform are different (e.g., with remote execution). Closes bazelbuild#15785. PiperOrigin-RevId: 461897893 Change-Id: I734ccdd1ae13e7c625cc22c894bc482fe080d70b
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
This increases the compatibility for builds where host and exec platform are different (e.g., with remote execution). Closes bazelbuild#15785. PiperOrigin-RevId: 461897893 Change-Id: I734ccdd1ae13e7c625cc22c894bc482fe080d70b
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
This increases the compatibility for builds where host and exec platform are different (e.g., with remote execution). Closes bazelbuild#15785. PiperOrigin-RevId: 461897893 Change-Id: I734ccdd1ae13e7c625cc22c894bc482fe080d70b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the compatibility for builds where host and exec platform
are different (e.g., with remote execution).