Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior of print() in module extensions #15795

Closed
wants to merge 1 commit into from
Closed

Fix behavior of print() in module extensions #15795

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 3, 2022

Previously, messages printed with print() didn't have the usual
DEBUG: prefix.

Fixes #14526

@fmeum
Fix behavior of print() in module extensions
892bdc5 
Previously, messages printed with `print()` didn't have the usual
`DEBUG:` prefix.

Fixes bazelbuild#14526
@fmeum fmeum marked this pull request as ready for review July 3, 2022 10:12
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 3, 2022

@meteorcloudy @Wyverald I noticed that the bzlmod parts of the codebase don't have you listed as CODEOWNERS, so reviewers don't get assigned automatically. Would it make sense to add you for e.g. src/main/java/com/google/devtools/build/lib/bazel/bzlmod, src/test/java/com/google/devtools/build/lib/bazel/bzlmod and src/test/py/bazel/bzlmod?

@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Jul 4, 2022
@meteorcloudy
Copy link
Member

I noticed that the bzlmod parts of the codebase don't have you listed as CODEOWNERS

Will do it, thanks for the notice!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 4, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 4, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 4, 2022
@meteorcloudy
Copy link
Member

@bazel-io fork 5.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 4, 2022
@bazel-io bazel-io mentioned this pull request Jul 4, 2022
Closed
@copybara-service copybara-service bot closed this in afb434d Jul 5, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 5, 2022
sgowroji pushed a commit to sgowroji/bazel that referenced this pull request Jul 14, 2022
@fmeum
Fix behavior of print() in module extensions
dc99192 
Previously, messages printed with `print()` didn't have the usual
`DEBUG:` prefix.

Fixes bazelbuild#14526

Closes bazelbuild#15795.

PiperOrigin-RevId: 459052873
Change-Id: I1b75498d448aaae137dd63ea0a418572097bdac2
@sgowroji sgowroji mentioned this pull request Jul 14, 2022
Merged
sgowroji added a commit that referenced this pull request Jul 15, 2022
@sgowroji @fmeum @ckolli5
Fix behavior of print() in module extensions (#15883)
dc65cff 
Previously, messages printed with `print()` didn't have the usual
`DEBUG:` prefix.

Fixes #14526

Closes #15795.

PiperOrigin-RevId: 459052873
Change-Id: I1b75498d448aaae137dd63ea0a418572097bdac2

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print in a module appears to be different from print in a workspace rule
5 participants
@fmeum @meteorcloudy @Wyverald @bazel-io @sgowroji