RemoteExecutionService: fix outputs not being uploaded #15823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Can you please also add an integration test for this case so we won't break combined cache again in the future? |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sluongng
force-pushed
the
sluongng/remote-cache-fix
branch
from
7866074
to
1832fee
Compare
sluongng
commented
Jul 7, 2022
|
CI passed @coeuvre PTAL |
coeuvre
approved these changes
Jul 7, 2022
In 4d900ce we introduced validation in DiskAndRemoteCacheClient.uploadActionResult() where context's step must be UPLOAD_OUTPUTS to trigger the upload. However, this value was never set in RemoteExecutionService before hand thus led to outputs not being uploaded and cause remote cache misses. Fix bazelbuild#15682
sluongng
force-pushed
the
sluongng/remote-cache-fix
branch
from
1832fee
to
28d1339
Compare
coeuvre
approved these changes
Jul 7, 2022
|
@bazel-io fork 5.3.0 |
bazel-io
removed
the
potential release blocker
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
In 4d900ce we introduced validation in DiskAndRemoteCacheClient.uploadActionResult() where context's step must be UPLOAD_OUTPUTS to trigger the upload. However, this value was never set in RemoteExecutionService before hand thus led to outputs not being uploaded and cause remote cache misses. Fix bazelbuild#15682 Thanks @adam-singer for doing the investigation 🙏 Closes bazelbuild#15823. PiperOrigin-RevId: 459519852 Change-Id: Ib004403d7893fe135adcc4b181b607d8cb33f3af
aranguyen
pushed a commit
to aranguyen/bazel
that referenced
this pull request
Jul 20, 2022
In 4d900ce we introduced validation in DiskAndRemoteCacheClient.uploadActionResult() where context's step must be UPLOAD_OUTPUTS to trigger the upload. However, this value was never set in RemoteExecutionService before hand thus led to outputs not being uploaded and cause remote cache misses. Fix bazelbuild#15682 Thanks @adam-singer for doing the investigation 🙏 Closes bazelbuild#15823. PiperOrigin-RevId: 459519852 Change-Id: Ib004403d7893fe135adcc4b181b607d8cb33f3af
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4d900ce we introduced validation in
DiskAndRemoteCacheClient.uploadActionResult() where context's step must
be UPLOAD_OUTPUTS to trigger the upload.
However, this value was never set in RemoteExecutionService before hand
thus led to outputs not being uploaded and cause remote cache misses.
Fix #15682
Thanks @adam-singer for doing the investigation 🙏