Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string_list flags to be set via repeated flag uses #15943

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Allow string_list flags to be set via repeated flag uses #15943

merged 2 commits into from
Jul 22, 2022

Commits on Jul 21, 2022

  1. Allow string_list flags to be set via repeated flag uses 

    For all parts of Bazel other than option parsing, string build setting
flags with `allow_multiple = True` should behave just like `string_list`
settings, even though they are fundamentally of a different type. This
requires a lot of special casing all over the code base and also causes
confusing user-facing behavior when transitioning on such settings.

This commit deprecates the `allow_multiple` named parameter of
`config.string` and as a replacement introduces a new named parameter
`repeatable` on `config.string_list`. Settings with the latter set to True
behave exactly like `string` settings with `allow_multiple = True` with
respect to command-line option parsing and exactly like ordinary
`string_list` flags in all other situations.

Fixes bazelbuild#13817

Closes bazelbuild#14911.

PiperOrigin-RevId: 462146752
Change-Id: I91ddc4328a1b2244f4303fcda7b4228b182a5d56
    @fmeum @ckolli5
    fmeum authored and ckolli5 committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    5d1a54f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-5.3.0' into ck/cherry_pick_14911

    @ckolli5
    ckolli5 authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    b2a0bb2 View commit details
    Browse the repository at this point in the history