Update upb to the latest in 21.x branch #16343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philwo could you upload https://github.com/protocolbuffers/upb/archive/a5477045acaa34586420942098f5fecd3570f577.tar.gz to https://mirror.bazel.build/github.com/protocolbuffers/upb/archive/a5477045acaa34586420942098f5fecd3570f577.tar.gz in order to proceed with this PR? Thanks |
|
There is a special issue template for mirror requests. @sgowroji |
Oh sorry for that, it seems that I was using outdated information bazelbuild/rules_python#400 (comment) |
|
Ok found, I will fill it https://groups.google.com/g/bazel-discuss/c/nMMztgTGdQA |
|
Hello @limdor, Updated here #16344 (comment) |
Some of the commits needed from this branch are: - Do not have globs that do not glob anything - Do not use platfroms from bazel_tools This is needed in order to flip the disallowance of empty globs
sgowroji
added
team-OSS
meteorcloudy
approved these changes
Oct 18, 2022
meteorcloudy
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the commits needed from this branch are:
This is needed in order to flip the disallowance of empty globs