Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bazel hanging when outputs got evicted from remote execution cache with --remote_download_toplevel enabled #16423

Closed

Conversation

k1nkreet
Copy link

@k1nkreet k1nkreet commented Oct 7, 2022

#16422 This PR removes ignoring exception from upload task which leads to Bazel hanging in scenario represented in this issue

@k1nkreet k1nkreet requested a review from a team as a code owner October 7, 2022 14:59
@google-cla
Copy link

google-cla bot commented Oct 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ShreeM01 ShreeM01 added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Oct 8, 2022
@coeuvre
Copy link
Member

coeuvre commented Oct 10, 2022

Thanks! Can you please also add a test for this?

@coeuvre
Copy link
Member

coeuvre commented Oct 13, 2022

I created #16464 and included the test there.

@k1nkreet
Copy link
Author

Thanks!

coeuvre added a commit to coeuvre/bazel that referenced this pull request Nov 22, 2022
Fixes bazelbuild#16422.

Closes bazelbuild#16423.
Closes bazelbuild#16445.

Closes bazelbuild#16464.

PiperOrigin-RevId: 480896881
Change-Id: I33019dbe8a088410280759465100a512a0f61bc1
ShreeM01 pushed a commit that referenced this pull request Nov 22, 2022
Fixes #16422.

Closes #16423.
Closes #16445.

Closes #16464.

PiperOrigin-RevId: 480896881
Change-Id: I33019dbe8a088410280759465100a512a0f61bc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants