Make bazel coverage work with minimal mode
#16556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
reviewed
Oct 26, 2022
src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java
Outdated
Show resolved
Hide resolved
This was referenced Oct 26, 2022
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
So spawns can read content of directires within action exuection. Part of #16556. PiperOrigin-RevId: 486918859 Change-Id: Ida86e4c927093d26f7f96d2f0c2aa0d1d74cc8a4
coeuvre
force-pushed
the
coverage-bwob
branch
from
bf2d932
to
63204a2
Compare
coeuvre
force-pushed
the
coverage-bwob
branch
from
996a6df
to
d135463
Compare
|
@coeuvre Can this get cherry-picked into 6.1.0? |
|
Yes, I believe this is a safe change. |
|
@bazel-io fork 6.1.0 |
coeuvre
added a commit
to coeuvre/bazel
that referenced
this pull request
Feb 2, 2023
This PR solves the problem in a different way that bazelbuild#16475 tries to solve: 1. bazelbuild#16812 allows skyframe read metadata from ActionFS. 2. Use `ActionFileSystem` to check existence of coverage data. 3. Fire event `CoverageReport` in the action after the coverage report is generated and listen to it in `ToplevelArtifactsDownloader` to download the report. Closes bazelbuild#16556. PiperOrigin-RevId: 502854552 Change-Id: I2796baaa962857831ff161423be6dffa6eb73e5c
ShreeM01
added a commit
that referenced
this pull request
Feb 7, 2023
* Returns null if filesystem of test outputs is not ActionFS when processing test attempt event. Previously, we assert that the filesystem of test outputs is ActionFS when we are processing test attempt event. However this is not true when the test hits action cache. This CL looses the check to return null. PiperOrigin-RevId: 501023752 Change-Id: I17cbb26e0a2b5fd30cb781818e42172ac672919e * Make `bazel coverage` work with minimal mode This PR solves the problem in a different way that #16475 tries to solve: 1. #16812 allows skyframe read metadata from ActionFS. 2. Use `ActionFileSystem` to check existence of coverage data. 3. Fire event `CoverageReport` in the action after the coverage report is generated and listen to it in `ToplevelArtifactsDownloader` to download the report. Closes #16556. PiperOrigin-RevId: 502854552 Change-Id: I2796baaa962857831ff161423be6dffa6eb73e5c --------- Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
This PR solves the problem in a different way that #16475 tries to solve: 1. #16812 allows skyframe read metadata from ActionFS. 2. Use `ActionFileSystem` to check existence of coverage data. 3. Fire event `CoverageReport` in the action after the coverage report is generated and listen to it in `ToplevelArtifactsDownloader` to download the report. Closes #16556. PiperOrigin-RevId: 502854552 Change-Id: I2796baaa962857831ff161423be6dffa6eb73e5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem in a different way that #16475 tries to solve:
ActionFileSystemto read directory output for coverage data.CoverageReportin the action after the coverage report is generated and listen to it inToplevelArtifactsDownloaderto download the report.