Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cc] Add cc toolchain to starlark cc_proto_library #16585

Closed
wants to merge 5 commits into from
Closed

[cc] Add cc toolchain to starlark cc_proto_library #16585

wants to merge 5 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Oct 27, 2022

Fixes #16577

@Yannic Yannic mentioned this pull request Oct 27, 2022
Closed
@Yannic
Copy link
Contributor Author

Yannic commented Oct 27, 2022

cc @buildbreaker2021 @meteorcloudy

@sgowroji sgowroji added the team-Rules-CPP Issues for C++ rules label Oct 27, 2022
@fmeum
Copy link
Collaborator

fmeum commented Nov 2, 2022

@buildbreaker2021 Could you review? This has the fix for the fix as well as an integration test.

@buildbreaker2021 buildbreaker2021 added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 2, 2022
@copybara-service copybara-service bot closed this in 6c1e4b7 Nov 2, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 2, 2022
@ShreeM01 ShreeM01 mentioned this pull request Nov 4, 2022
Merged
ShreeM01 added a commit that referenced this pull request Nov 4, 2022
@ShreeM01 @Yannic
[cc] Add cc toolchain to starlark cc_proto_library (#16661)
72e6e94 
Fixes #16577

Closes #16585.

PiperOrigin-RevId: 485600476
Change-Id: I3c2985731ff800a2c6136f401ed3c7e5e89518ad

Co-authored-by: Yannic <contact@yannic-bonenberger.com>
lripoche pushed a commit to lripoche/bazel that referenced this pull request Jun 13, 2023
@Yannic
[cc] Add cc toolchain to starlark cc_proto_library
176bb46 
Fixes bazelbuild#16577

Closes bazelbuild#16585.

PiperOrigin-RevId: 485600476
Change-Id: I3c2985731ff800a2c6136f401ed3c7e5e89518ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum left review comments

@buildbreaker2021 buildbreaker2021 buildbreaker2021 approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[6.0.0rc1] cc_proto_library analysis failure
4 participants
@Yannic @fmeum @buildbreaker2021 @sgowroji