Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --experimental_enable_objc_cc_deps #16641

Conversation

keith
Copy link
Member

@keith keith commented Nov 2, 2022

This was flipped in 2017

@keith keith requested a review from lberki as a code owner November 2, 2022 20:46
@lberki lberki requested review from susinmotion and removed request for lberki November 3, 2022 07:37
@keith keith force-pushed the ks/remove-experimental_enable_objc_cc_deps branch from aefe1fc to 66e02c4 Compare January 10, 2023 21:30
@keith
Copy link
Member Author

keith commented Jan 12, 2023

@susinmotion have time to check out this small cleanup?

@keith
Copy link
Member Author

keith commented Apr 3, 2023

@googlewalt have time for this small cleanup?

@keith keith force-pushed the ks/remove-experimental_enable_objc_cc_deps branch from 66e02c4 to 2a17cc7 Compare August 10, 2023 17:00
@brentleyjones
Copy link
Contributor

@bazelbuild/triage Can we get someone to review this please? 🙏

@googlewalt
Copy link
Contributor

Sorry for the delay. I'll review it.

@brentleyjones brentleyjones requested review from googlewalt and removed request for susinmotion August 10, 2023 18:33
@googlewalt
Copy link
Contributor

Thanks for checking. I will merge it.

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Aug 10, 2023
@keith keith deleted the ks/remove-experimental_enable_objc_cc_deps branch August 10, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-ObjC Issues for Objective-C maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants