Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bash runfiles library repo mapping aware #16693

Closed
wants to merge 3 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 8, 2022

Work towards #16124

@fmeum fmeum force-pushed the 16124-bash-current-repository branch 12 times, most recently from 7b15eec to c920817 Compare November 8, 2022 18:45
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

Stacked on #16652, so please ignore the first commit.

@fmeum fmeum force-pushed the 16124-bash-current-repository branch from 24744f5 to a261b3b Compare November 8, 2022 19:15
@fmeum fmeum changed the title Implement runfiles_current_repository in bash runfiles library Make Bash runfiles library repo mapping aware Nov 8, 2022
@fmeum fmeum force-pushed the 16124-bash-current-repository branch from a261b3b to d9d075d Compare November 8, 2022 19:35
@fmeum fmeum marked this pull request as ready for review November 8, 2022 19:38
@fmeum fmeum force-pushed the 16124-bash-current-repository branch from 6d7de6b to b155f93 Compare November 8, 2022 20:26
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

The test uncovered a minor bug in the runfiles library init code on macOS. Since I am bumping the version anyway, is it okay to keep the fix in this PR?

@ShreeM01 ShreeM01 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Nov 8, 2022
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 8, 2022

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 8, 2022
@lberki lberki removed their request for review November 9, 2022 08:16
@meteorcloudy
Copy link
Member

@bazel-io fork 6.0.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Nov 9, 2022
@fmeum fmeum force-pushed the 16124-bash-current-repository branch from 2c9c452 to 0e7c19c Compare November 9, 2022 20:40
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 9, 2022
@fmeum fmeum force-pushed the 16124-bash-current-repository branch from 0e7c19c to b3cf14d Compare November 10, 2022 15:59
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 10, 2022

Rebased and no longer stacked.

@fmeum fmeum deleted the 16124-bash-current-repository branch November 11, 2022 22:58
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 11, 2022
Work towards bazelbuild#16124

Closes bazelbuild#16693.

PiperOrigin-RevId: 487811689
Change-Id: Iec5ef01ae09394372b87e5cb697ceb728563d2dc
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 14, 2022
fmeum added a commit to fmeum/bazel that referenced this pull request Nov 15, 2022
Work towards bazelbuild#16124

Closes bazelbuild#16693.

PiperOrigin-RevId: 487811689
Change-Id: Iec5ef01ae09394372b87e5cb697ceb728563d2dc
ShreeM01 pushed a commit that referenced this pull request Nov 15, 2022
Work towards #16124

Closes #16693.

PiperOrigin-RevId: 487811689
Change-Id: Iec5ef01ae09394372b87e5cb697ceb728563d2dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants