Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make C++ runfiles library build with -Werror=shadow #16801

Closed
wants to merge 1 commit into from
Closed

Make C++ runfiles library build with -Werror=shadow #16801

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Nov 18, 2022

Fixes #16796

@fmeum fmeum mentioned this pull request Nov 18, 2022
Closed
@fmeum
Copy link
Collaborator Author

fmeum commented Nov 18, 2022

@oquenchil Could you review?

@jwnimmer-tri
Copy link
Contributor

LGTM, thanks!

@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 19, 2022
@oquenchil oquenchil added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Nov 22, 2022
@ShreeM01 ShreeM01 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Nov 28, 2022
@ShreeM01 ShreeM01 mentioned this pull request Nov 28, 2022
Merged
Wyverald pushed a commit that referenced this pull request Nov 29, 2022
@ShreeM01 @fmeum
Make C++ runfiles library build with -Werror=shadow (#16869)
fcf2522 
Fixes #16796

Closes #16801.

PiperOrigin-RevId: 491349584
Change-Id: I7498d9343a5d7849e2d726fbc1e5447178c39d79

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum deleted the 16796-fix-runfiles-compilation branch November 30, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oquenchil oquenchil oquenchil approved these changes

Assignees
No one assigned
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failure in C++ runfiles.h under Werror=shadow
5 participants
@fmeum @jwnimmer-tri @oquenchil @sgowroji @ShreeM01