Make Java runfiles library compilable with JDK 8 #16851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `FileReader(String,Charset)` constructor is not available in Java 8.
|
@Wyverald Could you review? I wonder whether there is any way to add test coverage for this. As far as I can tell, none of the CI images ship with Java 8 anymore. |
sgowroji
added
team-Rules-Java
Indeed, I think maintaining Java 8 compatibility is a best effort now. |
meteorcloudy
approved these changes
Nov 28, 2022
meteorcloudy
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Nov 28, 2022
The `FileReader(String,Charset)` constructor is not available in Java 8. Fixes bazelbuild#16849 Work towards bazelbuild#16124 Closes bazelbuild#16851. PiperOrigin-RevId: 491310720 Change-Id: I26f7bce346038d10285b0a1ee7b29216ba151010
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileReader(String,Charset)constructor is not available in Java 8.Fixes #16849
Work towards #16124