make desugar dependencies deterministic #16859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamadk
requested review from
ahumesky,
ted-xie and
kevin1e100
as code owners
sgowroji
added
awaiting-user-response
mohamadk
force-pushed
the
desugare_dependencies_are_not_deterministic
branch
3 times, most recently
from
d383b5a
to
49e7027
Compare
sgowroji
added
awaiting-review
ahumesky
reviewed
Nov 29, 2022
...ava/com/google/devtools/build/android/desugar/dependencies/DesugarDependencyInfoWrapper.java
Outdated
Show resolved
Hide resolved
mohamadk
force-pushed
the
desugare_dependencies_are_not_deterministic
branch
from
49e7027
to
8713a8e
Compare
ahumesky
reviewed
Nov 30, 2022
...s/android/java/com/google/devtools/build/android/desugar/dependencies/MetadataCollector.java
Outdated
Show resolved
Hide resolved
...s/android/java/com/google/devtools/build/android/desugar/dependencies/MetadataCollector.java
Outdated
Show resolved
Hide resolved
mohamadk
force-pushed
the
desugare_dependencies_are_not_deterministic
branch
from
8713a8e
to
45b6a80
Compare
desugar dependencies are added to the result jar file as metadata, this desugar dependency object contain few list that we found out the order of this list can be different in different build with same inputs, therefore final result will have a different hash and it cause cache miss in the builds solution is to make the lists in this object sorted. so for the same input we always get same output
mohamadk
force-pushed
the
desugare_dependencies_are_not_deterministic
branch
from
45b6a80
to
94b3d5e
Compare
|
thanks, I can start the import and internal review today |
ahumesky
pushed a commit
to ahumesky/bazel
that referenced
this pull request
Jan 13, 2023
Desugar dependencies are added to the result jar file as metadata, this desugar dependency object contains a few lists that we found out the order of this list can be different in different builds with the same inputs, therefore the final result will have a different hash and it cause cache miss in the builds solution is to make the lists in this object sorted. So for the same input, we always get the same output Closes bazelbuild#16859. PiperOrigin-RevId: 500842557 Change-Id: I051e74e7147d590fcfe5cda9731b8e012396bb65
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Desugar dependencies are added to the result jar file as metadata, this desugar dependency object contains a few lists that we found out the order of this list can be different in different builds with the same inputs, therefore the final result will have a different hash and it cause cache miss in the builds solution is to make the lists in this object sorted. So for the same input, we always get the same output Closes #16859. PiperOrigin-RevId: 500842557 Change-Id: I051e74e7147d590fcfe5cda9731b8e012396bb65
|
@bazel-io fork 6.1.0 |
ShreeM01
added a commit
that referenced
this pull request
Feb 28, 2023
Desugar dependencies are added to the result jar file as metadata, this desugar dependency object contains a few lists that we found out the order of this list can be different in different builds with the same inputs, therefore the final result will have a different hash and it cause cache miss in the builds solution is to make the lists in this object sorted. So for the same input, we always get the same output Closes #16859. PiperOrigin-RevId: 500842557 Change-Id: I051e74e7147d590fcfe5cda9731b8e012396bb65 Co-authored-by: mohamadk <mohamad.khaleghy@gmail.com> Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desugar dependencies are added to the result jar file as metadata, this desugar dependency object contains a few lists that we found out the order of this list can be different in different builds with the same inputs, therefore the final result will have a different hash and it cause cache miss in the builds solution is to make the lists in this object sorted. So for the same input, we always get the same output