Dont query remote cache but always use bytestream protocol #17025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coeuvre
force-pushed
the
fix-16999
branch
2 times, most recently
from
c1f8db5
to
308cddb
Compare
brentleyjones
approved these changes
Dec 14, 2022
|
|
||
| function append_remote_cas_files() { | ||
| find "$cas_path/cas" -type f >> $1 | ||
| } |
There was a problem hiding this comment.
Nit: should have a trailing newline here.
|
@bazel-io flag (for 6.1.0) |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
sgowroji
added
team-Remote-Exec
|
Friendly post-holiday ping @tjgq 🙏. |
This was referenced Jan 21, 2023
ShreeM01
added a commit
that referenced
this pull request
Jan 30, 2023
When using `--experimental_remote_build_event_upload=minimal`, instead of querying remote cache to decide whether convert local path of a file to `bytestream://`, it now always use `bytestream://` for BEP referenced files. Closes #16999. Closes #17025. PiperOrigin-RevId: 502351401 Change-Id: Ic858367ffaf3c2a2c20db88ada85fbbe1d93aae8 Co-authored-by: Chi Wang <chiwang@google.com>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
When using `--experimental_remote_build_event_upload=minimal`, instead of querying remote cache to decide whether convert local path of a file to `bytestream://`, it now always use `bytestream://` for BEP referenced files. Closes #16999. Closes #17025. PiperOrigin-RevId: 502351401 Change-Id: Ic858367ffaf3c2a2c20db88ada85fbbe1d93aae8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--experimental_remote_build_event_upload=minimal, instead of querying remote cache to decide whether convert local path of a file tobytestream://, it now always usebytestream://for BEP referenced files.Closes #16999.