Report AspectCreationException to the user
#17071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ec4be00, `AspectCreationException`s were no longer reported to the user, resulting in error messages such as: ``` ERROR: Analysis of target '//pkg:foo' failed; build aborted: ``` With this commit, the error looks like this instead: ``` ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...> ``` Context: bazelbuild/bazel-central-registry#327
fmeum
force-pushed
the
report-aspect-creation-exception
branch
from
eabfb2a
to
d6dce0b
Compare
|
I guess ideally this should be cherry picked for both 6.x and 5.x (if we make a new minor/patch release)? |
meteorcloudy
added
the
awaiting-PR-merge
gregestren
approved these changes
Jan 4, 2023
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
meteorcloudy
pushed a commit
that referenced
this pull request
Jan 20, 2023
Since ec4be00, `AspectCreationException`s are no longer reported to the user, resulting in error messages such as: ``` ERROR: Analysis of target '//pkg:foo' failed; build aborted: ``` With this commit, the error looks like this instead: ``` ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...> ``` Context: bazelbuild/bazel-central-registry#327 Closes #17071. PiperOrigin-RevId: 500883551 Change-Id: Iaf3b1dff8cb0915dd1ddc51d1d5e6578ff44029b Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Since ec4be00, `AspectCreationException`s are no longer reported to the user, resulting in error messages such as: ``` ERROR: Analysis of target '//pkg:foo' failed; build aborted: ``` With this commit, the error looks like this instead: ``` ERROR: Evaluation of aspect //aspects:aspects.bzl%my_aspect on //pkg:foo failed: <causes...> ``` Context: bazelbuild/bazel-central-registry#327 Closes #17071. PiperOrigin-RevId: 500883551 Change-Id: Iaf3b1dff8cb0915dd1ddc51d1d5e6578ff44029b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ec4be00,
AspectCreationExceptions are no longer reported to the user, resulting in error messages such as:With this commit, the error looks like this instead:
Context: bazelbuild/bazel-central-registry#327