Rollback #14510 because it causes remote test execution to fail #17147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fail When the parent process is run as a different user to the test itself (as can happen in some remote build environments, such as buildbarn) using `kill -0 $PPID` fails, causing the test to be prematurely killed. This PR rolls back the (nicer, cleaner, not always working) fix and replaces it with the (less nice, less clean, more often working) check that was there before. Tested with a local build against buildbarn.
|
One optimisation we might be able to do is to check for the presence of |
|
Not being able to run tests remotely is preventing my organisation from being able to update to Bazel 6, so once this lands, could it please be cherry-picked into the next release? |
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
larsrc-google
approved these changes
Jan 9, 2023
larsrc-google
added
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 25, 2023
When the parent process is run as a different user to the test itself (as can happen in some remote build environments, such as buildbarn) using `kill -0 $PPID` fails, causing the test to be prematurely killed. This PR rolls back the (nicer, cleaner, not always working) fix and replaces it with the (less nice, less clean, more often working) check that was there before. Tested with a local build against buildbarn. Closes #17147. PiperOrigin-RevId: 500691976 Change-Id: Ife55db5c1ed88d40ba502257ce9b679b04eeb179 Co-authored-by: Simon Mavi Stewart <simon_stewart@apple.com>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
When the parent process is run as a different user to the test itself (as can happen in some remote build environments, such as buildbarn) using `kill -0 $PPID` fails, causing the test to be prematurely killed. This PR rolls back the (nicer, cleaner, not always working) fix and replaces it with the (less nice, less clean, more often working) check that was there before. Tested with a local build against buildbarn. Closes #17147. PiperOrigin-RevId: 500691976 Change-Id: Ife55db5c1ed88d40ba502257ce9b679b04eeb179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parent process is run as a different user to the test itself (as can happen in some remote build environments, such as buildbarn) using
kill -0 $PPIDfails, causing the test to be prematurely killed.This PR rolls back the (nicer, cleaner, not always working) fix and replaces it with the (less nice, less clean, more often working) check that was there before.
Tested with a local build against buildbarn.