Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have 'bazel test' non-test targets depend on --remote_download_output #17195

Closed
wants to merge 1 commit into from
Closed

have 'bazel test' non-test targets depend on --remote_download_output #17195

wants to merge 1 commit into from

Conversation

antter
Copy link
Contributor

@antter antter commented Jan 11, 2023

This fixes #17190

@antter antter requested a review from a team as a code owner January 11, 2023 23:32
coeuvre
coeuvre approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@coeuvre
Copy link
Member

coeuvre commented Jan 12, 2023

@bazel-io fork 6.1.0

@bazel-io bazel-io mentioned this pull request Jan 12, 2023
Closed
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 12, 2023
@Wyverald Wyverald closed this in e8182ce Jan 12, 2023
copybara-service bot pushed a commit that referenced this pull request Jan 16, 2023
@coeuvre @copybara-github
Add integration tests for #17195.
2b22bf0 
PiperOrigin-RevId: 502341854
Change-Id: I2d5d60d218359621b91f48528aa0b49c319db767
@ShreeM01 ShreeM01 mentioned this pull request Jan 17, 2023
Merged
ShreeM01 added a commit that referenced this pull request Jan 19, 2023
@ShreeM01 @antter
have 'bazel test' non-test targets depend on --remote_download_output (…
82e3dae 
…#17234)

This fixes #17190

Closes #17195.

PiperOrigin-RevId: 501555041
Change-Id: Ie52f72fb82912dde135eaa56c02d9756eb31365b

Co-authored-by: Anthony Ter-Saakov <anthonytersaakov@gmail.com>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@antter @hvadehra
have 'bazel test' non-test targets depend on --remote_download_output
33971f7 
This fixes #17190

Closes #17195.

PiperOrigin-RevId: 501555041
Change-Id: Ie52f72fb82912dde135eaa56c02d9756eb31365b
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
@coeuvre @hvadehra
Add integration tests for #17195.
598c780 
PiperOrigin-RevId: 502341854
Change-Id: I2d5d60d218359621b91f48528aa0b49c319db767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--remote-download-minimal does not behave correctly with RBE and bazel test.
2 participants
@antter @coeuvre