Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bash runfiles_current_repository for tools #17279

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 20, 2023

Shell scripts invoked as tools in actions are usually invoked with relative paths starting with bazel-out, which resulted in them being misclassified as from the main repo.

Shell scripts invoked as tools in actions are usually invoked with
relative paths starting with `bazel-out`, which resulted in them being
misclassified as from the main repo.
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 20, 2023

@Wyverald Could you review?

More context is at https://bazelbuild.slack.com/archives/C014RARENH0/p1674160715619479.

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 20, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 20, 2023
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@Wyverald Wyverald added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 20, 2023
@fmeum fmeum deleted the bash-runfiles-tools branch January 23, 2023 15:36
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 23, 2023

@Wyverald Could you flag for 6.1.0?

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 25, 2023
@ShreeM01
Copy link
Contributor

@bazel-io fork 6.1.0

ShreeM01 added a commit that referenced this pull request Feb 8, 2023
Shell scripts invoked as tools in actions are usually invoked with relative paths starting with `bazel-out`, which resulted in them being misclassified as from the main repo.

Closes #17279.

PiperOrigin-RevId: 503968803
Change-Id: Idec5d4ce576f0e5b0c8297128cc33ac928d5b04b

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
Shell scripts invoked as tools in actions are usually invoked with relative paths starting with `bazel-out`, which resulted in them being misclassified as from the main repo.

Closes #17279.

PiperOrigin-RevId: 503968803
Change-Id: Idec5d4ce576f0e5b0c8297128cc33ac928d5b04b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants