Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0]Only fetch @remote_coverage_tools when collecting coverage #17287

Merged
merged 9 commits into from
Feb 19, 2023
Merged

[6.1.0]Only fetch @remote_coverage_tools when collecting coverage #17287

merged 9 commits into from
Feb 19, 2023

Commits on Jan 27, 2023

  1. Only fetch @remote_coverage_tools when collecting coverage

    Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage.
    
    This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled.
    
    Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`.
    
    Fixes #15088
    
    Closes #16995.
    
    PiperOrigin-RevId: 498949871
    Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed
    fmeum authored and comius committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    232bf63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    46c62f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Configuration menu
    Copy the full SHA
    603c974 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Configuration menu
    Copy the full SHA
    194dc98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4e7a4e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3e9dcf8 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Update BUILD

    keertk authored Feb 19, 2023
    Configuration menu
    Copy the full SHA
    f7e91ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f385c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd563b9 View commit details
    Browse the repository at this point in the history