-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.1.0]Only fetch @remote_coverage_tools when collecting coverage #17287
Merged
keertk
merged 9 commits into
bazelbuild:release-6.1.0
from
ShreeM01:ks/cherry-pick16995
Feb 19, 2023
Merged
[6.1.0]Only fetch @remote_coverage_tools when collecting coverage #17287
keertk
merged 9 commits into
bazelbuild:release-6.1.0
from
ShreeM01:ks/cherry-pick16995
Feb 19, 2023
Commits on Jan 27, 2023
-
Only fetch @remote_coverage_tools when collecting coverage
Before this change, every test rule had an implicit dependency on `@bazel_tools//tools/test:coverage_report_generator`, even though this tool is only used when collecting coverage. This is fixed by moving it to `CoverageOptions` and using the late-bound default resolver to only create a dependency if coverage is enabled. Also adds `CoverageOptions` to the set of options classes trimmed by `--trim_test_configuration` so that, as before, changing `--coverage_report_generator` doesn't cause non-test rules to be reanalyzed. This behavior now extends to `--coverage_output_generator`. Fixes #15088 Closes #16995. PiperOrigin-RevId: 498949871 Change-Id: I2440fae2655bbb701e918ee2aa7acb008d8f97ed
Configuration menu - View commit details
-
Copy full SHA for 232bf63 - Browse repository at this point
Copy the full SHA 232bf63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c62f8 - Browse repository at this point
Copy the full SHA 46c62f8View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 603c974 - Browse repository at this point
Copy the full SHA 603c974View commit details
Commits on Feb 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 194dc98 - Browse repository at this point
Copy the full SHA 194dc98View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4e7a4e - Browse repository at this point
Copy the full SHA f4e7a4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e9dcf8 - Browse repository at this point
Copy the full SHA 3e9dcf8View commit details
Commits on Feb 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f7e91ab - Browse repository at this point
Copy the full SHA f7e91abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f385c3 - Browse repository at this point
Copy the full SHA 7f385c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd563b9 - Browse repository at this point
Copy the full SHA bd563b9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.