Specify tar file format explicitly #17679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-OSS
cwoerner
suggested changes
Mar 7, 2023
tools/build_defs/pkg/archive.py
Outdated
| @@ -47,7 +47,7 @@ def __init__(self, | |||
| self.preserve_mtime = preserve_tar_mtimes | |||
|
|
|||
| self.fileobj = None | |||
| self.tar = tarfile.open(name=name, mode=mode, fileobj=self.fileobj) | |||
| self.tar = tarfile.open(name=name, mode=mode, fileobj=self.fileobj, format=tarfile.GNU_FORMAT) | |||
There was a problem hiding this comment.
If you hope to push this upstream you shouldn't set format=tarfile.GNU_FORMAT in the tarfile.open method invocation, but rather define an additional named argument to the TarFileWriter constructor called "format" with a default value (e.g format=tarfile.DEFAULT), then pass that into the tarfile.open() function.
ahryniv
changed the title
aiuto
reviewed
Mar 28, 2023
There was a problem hiding this comment.
We will not take this patch. The internal pkg_tar is deprecated and slowly being removed. Users must migrate to https://github.com/bazelbuild/rules_pkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 3.8. default format of tarfiles was changed to
PAX_FORMAT.dpkgrejects deb packages that use tarfiles with PAX format with an "unsupported PAX tar header type" message.Added optional parameter
--formatto set tar format explicitly. If it's not settarfile.DEFAULT_FORMATwould be used.see related: